From owner-cvs-all@FreeBSD.ORG  Thu Jun  9 17:51:16 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.ORG
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9E29016A41C;
	Thu,  9 Jun 2005 17:51:16 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CA54943D4C;
	Thu,  9 Jun 2005 17:51:15 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.4/8.13.4) with ESMTP id j59HpEdJ064268;
	Thu, 9 Jun 2005 21:51:14 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
DomainKey-Signature: a=rsa-sha1; s=default; d=nagual.pp.ru; c=nofws; q=dns;
	h=received:date:from:to:cc:subject:message-id:
	mail-followup-to:references:mime-version:content-type:
	content-disposition:in-reply-to:user-agent;
	b=Y/J5C9SNY9WyQa0sOA4VVcIp7QMrMQZ/ScmNAU8z/Ui/6DUJvgSxzs0VULZaccoXq
	MBUI8xafQrtaxIMRYuQxg==
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.4/8.13.4/Submit) id j59HpEaG064267;
	Thu, 9 Jun 2005 21:51:14 +0400 (MSD) (envelope-from ache)
Date: Thu, 9 Jun 2005 21:51:13 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: Paul Saab <ps@FreeBSD.ORG>, mohan_srinivasan@yahoo.com
Message-ID: <20050609175113.GA64124@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	Paul Saab <ps@FreeBSD.ORG>, mohan_srinivasan@yahoo.com,
	src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
References: <200506091401.j59E14cT033280@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200506091401.j59E14cT033280@repoman.freebsd.org>
User-Agent: Mutt/1.5.9i
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/netinet tcp_sack.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jun 2005 17:51:16 -0000

On Thu, Jun 09, 2005 at 02:01:04PM +0000, Paul Saab wrote:
>   Modified files:
>     sys/netinet          tcp_sack.c 
>   Log:
>   Fix for a crash in tcp_sack_option() caused by hitting the limit on
>   the number of sack holes.

Some cut&paste mistake obviously happens. I see now _two_ identical
tcp_sackhole_insert() in tcp_sack.c v1.23:

                temp = tcp_sackhole_insert(tp, tp->snd_fack,sblkp->start,NULL);
                if (temp == NULL)
                        return 0;
                tcp_sackhole_insert(tp, tp->snd_fack, sblkp->start, NULL);

-- 
http://ache.pp.ru/