Date: Wed, 21 Dec 2005 13:57:59 +0800 (CST) From: Yen-Ming Lee <leeym@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: vsevolod@FreeBSD.org, girgen@FreeBSD.org Subject: ports/90730: databases/postgresql[0-9]*: check USE_PGSQL Message-ID: <20051221055759.D1E79B29D00@utopia.leeym.com> Resent-Message-ID: <200512210600.jBL60JXF067714@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 90730
>Category: ports
>Synopsis: databases/postgresql[0-9]*: check USE_PGSQL
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Dec 21 06:00:18 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Yen-Ming Lee
>Release: FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD utopia.leeym.com 6.0-STABLE FreeBSD 6.0-STABLE #0: Thu Nov 17 09:15:19 CST 2005 root@utopia.leeym.com:/usr/obj/usr/src/sys/UTOPIA i386
>Description:
- check USE_PGSQL in databases/postgresql[0-9]*
without checking USE_PGSQL, it will become a infinite loop for package dependency
(Cc-ed to the maintainers of databases/db* and bsd.database.mk)
>How-To-Repeat:
# cd /usr/ports && make clean USE_PGSQL=blah
(yes, it causes the loop in any port for any value)
>Fix:
--- pgsql.diff begins here ---
Index: postgresql73-server/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/postgresql73-server/Makefile,v
retrieving revision 1.138
diff -u -r1.138 Makefile
--- postgresql73-server/Makefile 14 Nov 2005 23:59:25 -0000 1.138
+++ postgresql73-server/Makefile 21 Dec 2005 05:53:57 -0000
@@ -29,6 +29,10 @@
UNIQUENAME?= ${PORTNAME}73
LATEST_LINK?= ${PKGNAMEPREFIX}${UNIQUENAME}${PKGNAMESUFFIX}
+.ifdef USE_PGSQL
+.error You have `USE_PGSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
PKGINSTALL?= ${PKGDIR}/pkg-install${PKGNAMESUFFIX}
USE_BZIP2= YES
USE_GMAKE= YES
Index: postgresql74-server/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/postgresql74-server/Makefile,v
retrieving revision 1.139
diff -u -r1.139 Makefile
--- postgresql74-server/Makefile 14 Nov 2005 23:59:25 -0000 1.139
+++ postgresql74-server/Makefile 21 Dec 2005 05:53:57 -0000
@@ -29,6 +29,10 @@
UNIQUENAME?= ${PORTNAME}74
LATEST_LINK?= ${PKGNAMEPREFIX}${UNIQUENAME}${PKGNAMESUFFIX}
+.ifdef USE_PGSQL
+.error You have `USE_PGSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
PKGINSTALL?= ${PKGDIR}/pkg-install${PKGNAMESUFFIX}
USE_BZIP2= YES
USE_GMAKE= YES
Index: postgresql80-server/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/postgresql80-server/Makefile,v
retrieving revision 1.150
diff -u -r1.150 Makefile
--- postgresql80-server/Makefile 29 Nov 2005 13:31:01 -0000 1.150
+++ postgresql80-server/Makefile 21 Dec 2005 05:53:58 -0000
@@ -27,6 +27,10 @@
UNIQUENAME?= ${PORTNAME}80
LATEST_LINK?= ${PKGNAMEPREFIX}${UNIQUENAME}${PKGNAMESUFFIX}
+.ifdef USE_PGSQL
+.error You have `USE_PGSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
PKGINSTALL?= ${PKGDIR}/pkg-install${PKGNAMESUFFIX}
USE_BZIP2= YES
USE_GMAKE= YES
Index: postgresql81-server/Makefile
===================================================================
RCS file: /home/pcvs/ports/databases/postgresql81-server/Makefile,v
retrieving revision 1.150
diff -u -r1.150 Makefile
--- postgresql81-server/Makefile 15 Nov 2005 06:48:23 -0000 1.150
+++ postgresql81-server/Makefile 21 Dec 2005 05:53:58 -0000
@@ -27,6 +27,10 @@
UNIQUENAME?= ${PORTNAME}81
LATEST_LINK?= ${PKGNAMEPREFIX}${UNIQUENAME}${PKGNAMESUFFIX}
+.ifdef USE_PGSQL
+.error You have `USE_PGSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
PKGINSTALL?= ${PKGDIR}/pkg-install${PKGNAMESUFFIX}
USE_BZIP2= YES
USE_GMAKE= YES
--- pgsql.diff ends here ---
:
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051221055759.D1E79B29D00>