From owner-svn-src-head@freebsd.org Fri Nov 13 21:03:02 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05B01A2EA71; Fri, 13 Nov 2015 21:03:02 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id DD78C189E; Fri, 13 Nov 2015 21:03:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id D47FA18B9; Fri, 13 Nov 2015 21:03:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 9CB2F16BE7; Fri, 13 Nov 2015 21:03:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id Gicq5AGir1tL; Fri, 13 Nov 2015 21:02:59 +0000 (UTC) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com B860F16BDE To: Randall Stewart References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> Cc: "Alexander V. Chernikov" , Randall Ray Stewart , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Adrian Chadd , imp@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56465003.8070709@FreeBSD.org> Date: Fri, 13 Nov 2015 13:02:59 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="G04tTwWnx6wA5vvXQ7sS2M6ihqaW0IFjv" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 21:03:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --G04tTwWnx6wA5vvXQ7sS2M6ihqaW0IFjv Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 11/13/2015 1:00 PM, Randall Stewart wrote: > Bryan: >=20 > This looks like a decent thing to do.. >=20 > Still wondering why changing the callout.h header file would not have c= aused > things to recompile to pick up the new argument.. >=20 > We can do it this way though it looks fine. >=20 > You want to commit it or I? Well your change is totally safe for compiling. It's just not KBI backwards compat for older modules. This is not typically a problem but I think in this case it is worth doing to avoid random data coming into the 'drain' argument if loading an older module. I'll do a test build and commit it. Perhaps this is what was leading to Alexander's panics. I haven't analyzed the return value issue at all. --=20 Regards, Bryan Drewery --G04tTwWnx6wA5vvXQ7sS2M6ihqaW0IFjv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWRlADAAoJEDXXcbtuRpfPnb4IANfTG0cl9GOtj5vhJEmsfyKs y9aqkIaAEvw/ApUp9X79crEjDguThTws+jultOyLel/O+moJ5edcV8Puqsbw5V+U +L9RCslkU4wxnChBJ09069iI2hcrAlxBvryQP8iQXDjus4t5DVYwawP2vPKNkidA fg8j5kgGLmR/6vtVWGv27gVsvqUEdIRvDIW6aGQq2wCzj99KKZE1KUa0IQYJztb5 J4E8FTAhl9VbbsPbUNiNt1p3qsuiFQQ/YpXuGtn4gjcCrU7IoxiStabymUtCI4Ad LMb/24/TWG+USGcqII5k2eh6J8zUWtKPmerL9mM1eIzNLVsPTZyPHJFjtlbDXvw= =et0M -----END PGP SIGNATURE----- --G04tTwWnx6wA5vvXQ7sS2M6ihqaW0IFjv--