From nobody Wed Jun 24 13:48:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gljvj3VV7z6jDdC for ; Wed, 24 Jun 2026 13:48:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gljvj2xDzz3tNX for ; Wed, 24 Jun 2026 13:48:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782308929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GTzrAufixw40FMSwx6pB7OqDkZUtnLLDdtAqU0WFDpo=; b=MnG2t4rAqMfnuZ+UuiO3OiOSSFQkkTiQuofOjpw83GsF2Tx40TD7J1E9/DiCQUobYWN3Cn pMToI5veHxjpipL47FxBMvidvB1BmKs8/DTkcOlMmD3VY+RwrDLoM7S+CJjsbPEu5mWdLI U3tsWU6Kgs2Q//xMm7jCMjryxq6P3sugd2ibe+Uwd8y5iSLkUs3WzWbvrDpH7ydSBK0Gya EvSQG9xgT813xYtk2NqkZn31eiyZIgD6rNgBgmzTu6IzUXEabq+SU5ueyoiyaAoPU6lWxY IbkBOhtJEwjnUitmYtli0A+duZWnKYCMZDNz5sMU5xz8g1EFkQ3/pgsZXCt1lg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782308929; a=rsa-sha256; cv=none; b=GDp8IPRMkqWTv3JsQdVNE/6O1Y9xB8AotTFK+9FnWY7HppebjtBP034FD5tDBcc9QrqnWN k/ZeT/UtnP0g+hD0WJ9OAQ1B5+gaYCUqpRLgYhA2qrU9F3wD8V6ZQYcGxQ9calFL6Gplaw LwNfjB2zLsDqcRIkDTbG+Hn6BPv2fZIUVXxzxwSPtrJ/Lc6HRI0FYvr/Nnh2GM8v/2fsjO Aua7hrq2rjiIlij9N5Fs59xDrhbOx52le+1IPD2i4uJBtwCY68PXYvhEL2WzdlDoubUjHJ /G7XYjszPgn1DQk6IXuwlVYQF7Zm6V6GgS5yr8nIasgT5sMKRcUJ1O4mbO2svQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782308929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GTzrAufixw40FMSwx6pB7OqDkZUtnLLDdtAqU0WFDpo=; b=S33UFNrOvZ0ikJL86eFNlZSRLeh0Xc9ixwxm2eMH0tDuWbeSSxaaAR2f/Kby40o2a1uS06 I0TKKsfhBVOuE0u+hx7Boq7G2grdC78+0ZJH7metNgulNSdV6CtARiz7NK1Er1RXqKEyjr Va9SqtSUupgsJ1Sym7QeA2BhcXX6Y2E470SbtEyqDrJWv46MoCQ+RFt9bwNePGdmnD9vAu qGzQYgvpFlOMeFbkLyWyGa17RCnrAnu7UP0g+77bXrRAtP9+zMxx9Pl+eTUTwkG4beX6qk LwnEoBwJ96yy1EntaaSILvhKhw3qLbfXwswK6KxhrsQe6Q6KVBI4DF0GJYWeIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gljvj1ZR9z6ty for ; Wed, 24 Jun 2026 13:48:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e59f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 24 Jun 2026 13:48:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: ede0236d3b34 - main - sound: Retire unused SD_F_EQ_PC List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ede0236d3b34a89bae7795f0f45696d4d94ce138 Auto-Submitted: auto-generated Date: Wed, 24 Jun 2026 13:48:44 +0000 Message-Id: <6a3be03c.3e59f.450de236@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=ede0236d3b34a89bae7795f0f45696d4d94ce138 commit ede0236d3b34a89bae7795f0f45696d4d94ce138 Author: Christos Margiolis AuthorDate: 2026-06-24 13:47:05 +0000 Commit: Christos Margiolis CommitDate: 2026-06-24 13:47:05 +0000 sound: Retire unused SD_F_EQ_PC This flag is neither set anywhere, nor is there a way to set it from userland, so it is effectively useless, and currently the effect is that EQ can only be enabled for primary playback channels. Retire the flag and keep this behavior, and think later whether we want to allow virtual channels to get their own EQ feeder as well. Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/dev/sound/pcm/feeder_chain.c | 6 ++---- sys/dev/sound/pcm/sound.h | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/sys/dev/sound/pcm/feeder_chain.c b/sys/dev/sound/pcm/feeder_chain.c index 1dbdf2fcc0e4..dc0788ffb53c 100644 --- a/sys/dev/sound/pcm/feeder_chain.c +++ b/sys/dev/sound/pcm/feeder_chain.c @@ -725,10 +725,8 @@ feeder_chain(struct pcm_channel *c) /* Soft EQ only applicable for PLAY. */ if (cdesc.dummy == 0 && - c->direction == PCMDIR_PLAY && (d->flags & SD_F_EQ_ENABLED) && - (((d->flags & SD_F_EQ_PC) && - !(c->flags & CHN_F_HAS_VCHAN)) || - (!(d->flags & SD_F_EQ_PC) && !(c->flags & CHN_F_VIRTUAL)))) + c->direction == PCMDIR_PLAY && + (d->flags & SD_F_EQ_ENABLED) && !(c->flags & CHN_F_VIRTUAL)) cdesc.use_eq = 1; if (FEEDFORMAT_NE_REQUIRED(&cdesc)) { diff --git a/sys/dev/sound/pcm/sound.h b/sys/dev/sound/pcm/sound.h index 60beee69d1a5..bfb0e259d510 100644 --- a/sys/dev/sound/pcm/sound.h +++ b/sys/dev/sound/pcm/sound.h @@ -108,7 +108,7 @@ struct snd_mixer; /* unused 0x00000100 */ #define SD_F_EQ_ENABLED 0x00000200 /* EQ enabled */ /* unused 0x00000400 */ -#define SD_F_EQ_PC 0x00000800 /* EQ per-channel */ +/* unused 0x00000800 */ #define SD_F_PVCHANS 0x00001000 /* Playback vchans enabled */ #define SD_F_RVCHANS 0x00002000 /* Recording vchans enabled */ @@ -124,7 +124,7 @@ struct snd_mixer; /* "\011 */ \ "\012EQ_ENABLED" \ /* "\013 */ \ - "\014EQ_PC" \ + /* "\014 */ \ "\015PVCHANS" \ "\016RVCHANS"