From owner-freebsd-bugs@FreeBSD.ORG Fri Sep 6 00:42:00 2013 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id BAEDF4D2; Fri, 6 Sep 2013 00:42:00 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from ch1outboundpool.messaging.microsoft.com (ch1ehsobe003.messaging.microsoft.com [216.32.181.183]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6B08D2AAD; Fri, 6 Sep 2013 00:41:59 +0000 (UTC) Received: from mail206-ch1-R.bigfish.com (10.43.68.245) by CH1EHSOBE022.bigfish.com (10.43.70.79) with Microsoft SMTP Server id 14.1.225.22; Fri, 6 Sep 2013 00:41:53 +0000 Received: from mail206-ch1 (localhost [127.0.0.1]) by mail206-ch1-R.bigfish.com (Postfix) with ESMTP id A40E01C01CA; Fri, 6 Sep 2013 00:41:52 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.224.54; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF01-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 2 X-BigFish: VPS2(zz1432Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6h1082kzz1de097hz2fh2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h1155h) Received-SPF: pass (mail206-ch1: domain of juniper.net designates 66.129.224.54 as permitted sender) client-ip=66.129.224.54; envelope-from=sjg@juniper.net; helo=P-EMF01-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail206-ch1 (localhost.localdomain [127.0.0.1]) by mail206-ch1 (MessageSwitch) id 1378428058766301_20388; Fri, 6 Sep 2013 00:40:58 +0000 (UTC) Received: from CH1EHSMHS042.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.250]) by mail206-ch1.bigfish.com (Postfix) with ESMTP id B6B574000DE; Fri, 6 Sep 2013 00:40:58 +0000 (UTC) Received: from P-EMF01-SAC.jnpr.net (66.129.224.54) by CH1EHSMHS042.bigfish.com (10.43.69.251) with Microsoft SMTP Server (TLS) id 14.16.227.3; Fri, 6 Sep 2013 00:40:58 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF01-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Thu, 5 Sep 2013 17:40:57 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id r860epL21983; Thu, 5 Sep 2013 17:40:55 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 006105807E; Thu, 5 Sep 2013 17:40:51 -0700 (PDT) To: Tijl Coosemans Subject: Re: bin/178819: bmake w/ WRKDIRPEFIX=/tmp breaks Ports Collection In-Reply-To: <20130905213942.007a0040@kalimero.tijl.coosemans.org> References: <201309030703.r8373BSU072280@freefall.freebsd.org> <20130905164552.3639E5807E@chaos.jnpr.net> <20130905175936.GB58718@FreeBSD.org> <20130905185758.7D04D5807E@chaos.jnpr.net> <20130905213942.007a0040@kalimero.tijl.coosemans.org> Comments: In-reply-to: Tijl Coosemans message dated "Thu, 05 Sep 2013 21:39:42 +0200." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Thu, 5 Sep 2013 17:40:50 -0700 Message-ID: <20130906004051.006105807E@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: bapt@FreeBSD.ORG, Alexey Dokuchaev , freebsd-bugs@FreeBSD.ORG X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 00:42:00 -0000 On Thu, 5 Sep 2013 21:39:42 +0200, Tijl Coosemans writes: >fmake does set it. It goes something like this: > >1) the port makefiles are all named Makefile so fmake sets > MAKEFILE=Makefile. With bmake this is sometimes an absolute path. IIRC it will be an absolute path anytime .OBJDIR!=.CURDIR >2) bsd.port.mk has MAKEFILE?=Makefile which doesn't do anything under > both fmake and bmake because it's already defined. True, but there a good number of places in ports where it is set to something else - eg irc/inspircd12/Makefile:51:MAKEFILE= BSDmakefile irc/trickyirc/Makefile:15:MAKEFILE= GNUmakefile these should work with the new bmake, but MAKEFILE?= Makefile won't. >3) bsd.port.mk runs something like "cd ${WRKSRC} && make -f ${MAKEFILE}" > This fails with bmake if MAKEFILE happens to be an absolute path > pointing to the port makefile (instead of the source code makefile). > With fmake this only works by accident. I suppose ${MAKEFILE:T} above wouldn't help... >bsd.port.mk should not try to reuse MAKEFILE like this. I once looked >into renaming this variable to MAKE_FILE but that affects many ports. Yes, I counted 925 places where MAKEFILE is set or referenced.