From owner-svn-src-head@freebsd.org Sun Aug 28 17:20:32 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC0CBB7824E; Sun, 28 Aug 2016 17:20:32 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7145DEC4; Sun, 28 Aug 2016 17:20:32 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-it0-x22e.google.com with SMTP id e63so71268326ith.1; Sun, 28 Aug 2016 10:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U0mG4G169clsLtQI7GCpWOZy8nbtd6XrAfW+Hv/b+zM=; b=wnSVSVf/zQcZEwDX3XDDjUdKWJLP/E+ZCWn+j0T5FCPW5vyQhOMZFAughG2tWgSiy0 uuxVCowTOor27nYG5Cai2KMJTqcDmmJ3tNDb50slDZhUtbX4xy6mWwe1Fs9m6jjutfoN 4PW0FAN+37P7nWxdxvAfkn3xI3Ld6pRkZitjU6w5eQld+3TbIkn7BF7RmsS8kOZ691Fy XNk44QRbx/J7fJEUMyr4qpq/LHnWR/EQrsNSQhMH7iPvLLcTwUwc/e1r5lnzaGby3YRG eaFufa94JHoVGMjkQBKdQzEq0HFIgG9QKBUAFnRB2j5rmMQR/df2viWvSVI3czwv9rTM 3N/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U0mG4G169clsLtQI7GCpWOZy8nbtd6XrAfW+Hv/b+zM=; b=k6/tZFkS3swH3k+JXuUTScXgDM05vf+bHaIAvNMJhqVd2rCwScbxOcl121P4QHmI1J ry7qIqrRh0hz+jXDgW/kViaGcsMy+GSIvGj/Be/Y7maOCUw3W31ULmIiqN2ewo8sRwYR kH98kzgL6Ei27FNkXBT/Se1x0/7d8o4JDwFNxfh8C4qUg+588KtzRFoWGUlSGNds7TIn 7aYCL1J9WQEx1xUujXNsIr/G+1dgilHmaBMG6Y8ZTtY2Wt06Gsbas7om5nwfXdAHTr9k wcN0OLkaCepko40hnJEWbR32b2uuR+YUPB8GoVu0Lim/tJZgQTb1pAU2tMPEISg2T7FI lk1A== X-Gm-Message-State: AE9vXwNf1Vf+RH/rgWKlha4aagbPOP5EZpQlMUFm/ZpRSPnK7E91MwVmLkiaewEZ378LL9E/8utewXNoW1KThw== X-Received: by 10.36.212.6 with SMTP id x6mr9037672itg.71.1472404831303; Sun, 28 Aug 2016 10:20:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.141.129 with HTTP; Sun, 28 Aug 2016 10:20:30 -0700 (PDT) In-Reply-To: References: <201608271522.u7RFMtBY006582@repo.freebsd.org> From: Adrian Chadd Date: Sun, 28 Aug 2016 10:20:30 -0700 Message-ID: Subject: Re: svn commit: r304912 - head/sys/sys To: Mariusz Zaborski Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Aug 2016 17:20:32 -0000 Thanks! -a On 28 August 2016 at 00:40, Mariusz Zaborski wrote: > Eh, sorry. > Fixed in the @304952. > > On 28 August 2016 at 06:17, Adrian Chadd wrote: >> ... >> >> ===> lib/libnv (obj,all,install) >> In file included from >> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libnv/../../sys/contrib/libnv/cnvlist.c:49:0: >> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libnv/../../sys/sys/cnv.h:107:6: >> error: redundant redeclaration of 'cnvlist_free_descriptor' >> [-Werror=redundant-decls] >> void cnvlist_free_descriptor(nvlist_t *nvl, void *cookiep); >> ^ >> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libnv/../../sys/sys/cnv.h:101:6: >> note: previous declaration of 'cnvlist_free_descriptor' was here >> void cnvlist_free_descriptor(nvlist_t *nvl, void *cookiep); >> ^ >> cc1: all warnings being treated as errors >> --- cnvlist.o --- >> *** [cnvlist.o] Error code 1 >> >> make[4]: stopped in /usr/home/adrian/work/freebsd/head-embedded/src/lib/libnv >> 1 error >> >> >> >> -a >> >> >> On 27 August 2016 at 08:22, Mariusz Zaborski wrote: >>> Author: oshogbo >>> Date: Sat Aug 27 15:22:55 2016 >>> New Revision: 304912 >>> URL: https://svnweb.freebsd.org/changeset/base/304912 >>> >>> Log: >>> Add missed header file for cnv.h . >>> >>> Submitted by: Adam Starak >>> Reported by: ache@ >>> >>> Added: >>> head/sys/sys/cnv.h (contents, props changed) >>> >>> Added: head/sys/sys/cnv.h >>> ============================================================================== >>> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >>> +++ head/sys/sys/cnv.h Sat Aug 27 15:22:55 2016 (r304912) >>> @@ -0,0 +1,113 @@ >>> +/*- >>> + * Copyright (c) 2016 Adam Starak >>> + * All rights reserved. >>> + * >>> + * Redistribution and use in source and binary forms, with or without >>> + * modification, are permitted provided that the following conditions >>> + * are met: >>> + * 1. Redistributions of source code must retain the above copyright >>> + * notice, this list of conditions and the following disclaimer. >>> + * 2. Redistributions in binary form must reproduce the above copyright >>> + * notice, this list of conditions and the following disclaimer in the >>> + * documentation and/or other materials provided with the distribution. >>> + * >>> + * THIS SOFTWARE IS PROVIDED BY THE AUTHORS AND CONTRIBUTORS ``AS IS'' AND >>> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE >>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE >>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHORS OR CONTRIBUTORS BE LIABLE >>> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL >>> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS >>> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) >>> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT >>> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY >>> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF >>> + * SUCH DAMAGE. >>> + * >>> + * $FreeBSD$ >>> + */ >>> + >>> +#ifndef _CNV_H_ >>> +#define _CNV_H_ >>> + >>> +#include >>> + >>> +#ifndef _KERNEL >>> +#include >>> +#include >>> +#include >>> +#include >>> +#endif >>> + >>> +#ifndef _NVLIST_T_DECLARED >>> +#define _NVLIST_T_DECLARED >>> +struct nvlist; >>> + >>> +typedef struct nvlist nvlist_t; >>> +#endif >>> + >>> +__BEGIN_DECLS >>> + >>> +/* >>> + * The cnvlist_get functions returns value associated with the given cookie. >>> + * If it returns a pointer, the pointer represents internal buffer and should >>> + * not be freed by the caller. >>> + */ >>> + >>> +bool cnvlist_get_bool(void *cookiep); >>> +uint64_t cnvlist_get_number(void *cookiep); >>> +const char *cnvlist_get_string(void *cookiep); >>> +const nvlist_t *cnvlist_get_nvlist(void *cookiep); >>> +const void *cnvlist_get_binary(void *cookiep, size_t *sizep); >>> +const bool *cnvlist_get_bool_array(void *cookiep, size_t *nitemsp); >>> +const uint64_t *cnvlist_get_number_array(void *cookiep, size_t *nitemsp); >>> +const char * const *cnvlist_get_string_array(void *cookiep, size_t *nitemsp); >>> +const nvlist_t * const *cnvlist_get_nvlist_array(void *cookiep, size_t *nitemsp); >>> +#ifndef _KERNEL >>> +int cnvlist_get_descriptor(void *cookiep); >>> +const int *cnvlist_get_descriptor_array(void *cookiep, size_t *nitemsp); >>> +#endif >>> + >>> + >>> +/* >>> + * The cnvlist_take functions returns value associated with the given cookie and >>> + * remove the given entry from the nvlist. >>> + * The caller is responsible for freeing received data. >>> + */ >>> + >>> +bool cnvlist_take_bool(nvlist_t *nvl, void *cookiep); >>> +uint64_t cnvlist_take_number(nvlist_t *nvl, void *cookiep); >>> +char *cnvlist_take_string(nvlist_t *nvl, void *cookiep); >>> +nvlist_t *cnvlist_take_nvlist(nvlist_t *nvl, void *cookiep); >>> +void *cnvlist_take_binary(nvlist_t *nvl, void *cookiep, size_t *sizep); >>> +bool *cnvlist_take_bool_array(nvlist_t *nvl, void *cookiep, size_t *nitemsp); >>> +uint64_t *cnvlist_take_number_array(nvlist_t *nvl, void *cookiep, size_t *nitemsp); >>> +char **cnvlist_take_string_array(nvlist_t *nvl, void *cookiep, size_t *nitemsp); >>> +nvlist_t **cnvlist_take_nvlist_array(nvlist_t *nvl, void *cookiep, size_t *nitemsp); >>> +#ifndef _KERNEL >>> +int cnvlist_take_descriptor(nvlist_t *nvl, void *cookiep); >>> +int *cnvlist_take_descriptor_array(nvlist_t *nvl, void *cookiep, size_t *nitemsp); >>> +#endif >>> + >>> +/* >>> + * The cnvlist_free functions removes the given name/value pair from the nvlist based on cookie >>> + * and frees memory associated with it. >>> + */ >>> + >>> +void cnvlist_free_bool(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_number(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_string(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_nvlist(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_binary(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_descriptor(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_bool_array(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_number_array(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_string_array(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_nvlist_array(nvlist_t *nvl, void *cookiep); >>> +#ifndef _KERNEL >>> +void cnvlist_free_descriptor(nvlist_t *nvl, void *cookiep); >>> +void cnvlist_free_descriptor_array(nvlist_t *nvl, void *cookiep); >>> +#endif >>> + >>> +__END_DECLS >>> + >>> +#endif /* !_CNV_H_ */ >>>