From nobody Wed Oct 25 15:03:19 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SFscm0yrCz4xd78; Wed, 25 Oct 2023 15:03:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SFscl3qpKz4RTS; Wed, 25 Oct 2023 15:03:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698246199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p9a1nPcN5hBo8hdXf1jQ9n8WILxN+FBB90hia2VKy8s=; b=E8mWnOLimhZqNERaZLhwLi6hXapxfvyK+yxf27ZF4psZu4fd3wbairOk8hqFkQzqRC68mN rLGwuSjo8ERcHvc1X96cHGRAGM/tcICdVbjTthFVhePTAHLT4PAjTRX4jbZk4zKse/F8X2 +/E5mueM2i4Ups4RIM7d7XifqQKerot+o8jHQyBTeOOGdJN3LlZM3frespunHxbS2QGSyM z5uBLHOMB/scYCnTaoaBlw/hicmA/Qt92/5tBs+bf8rUTBJzT1c3PxS44sV6rAeHWstc0F rXZ9a2XMnJuTkp/AsL5eOWkL3vpR2GMc7xkSFdsTEDJv6BlaBuZWFI2A8KXX7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698246199; a=rsa-sha256; cv=none; b=HBVZGa2ogvVT5nemQ9f+1TzctICufWjBa8ap4IH4PG+dYB9TX39F/W5esrU+R08YX05Yga ZCH+Bn+e0scF6b4sHoXdGZvBAUwlVBWEsZDB3EOmJCwT0lDSlZAnfNCod3Je+layxtowZN TgOpVYTui2Jflj+783FRULH/GEXAiBJilkZiwFYLBQan7HX5jxiWASNxHJsNjJevVv5peb L99V6eg8rxx3ar71hBD+Ro829vm9U3XmOI5oUICSIhK0q995gsxJS5DoBnBmQsthy8x0o3 59WDLMftpp0RgF2qa9IxCPrvThXc6a6011oD2bZLUYlrDP3GHbu1W1xal7wHrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698246199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p9a1nPcN5hBo8hdXf1jQ9n8WILxN+FBB90hia2VKy8s=; b=F2eYTBK2tLL24/swolm9Q904PMzPtDW0/4JP6aHyNCwZklxZdxNxMDBJ6cgQRu8UWvOc3D lRQD9m4l4x2jp/uz7OEjt5cSe8b4L8utjvJ9YG7THiIpl0q0f9f4rAy0jXG12m2kTHG48l dDQuj5Y5a7at+Fehm6fYT/dLISb2HBgUkRUD7bMu0B5AtarN9oUdG0eQxjNho2+65ekqXc R08BDGWP87l96Gbkv+UP5jtgLBNDtK0QR7jRKXIRaru6t5GtlSL+h9gzEuHFXpN/UgErR/ 2uIlV5HjyhUXkV7tMcEqFE5xxE/yh/thnstWmt9HmXsgYmYpVVBld5bazF6pYg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SFscl1Ndxz181s; Wed, 25 Oct 2023 15:03:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39PF3JLd039138; Wed, 25 Oct 2023 15:03:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39PF3JeF039135; Wed, 25 Oct 2023 15:03:19 GMT (envelope-from git) Date: Wed, 25 Oct 2023 15:03:19 GMT Message-Id: <202310251503.39PF3JeF039135@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: c9c029507f80 - stable/14 - makefs/zfs: Update dd_used_breakdown after writing the MOS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c9c029507f80b31fb67b1b545f3062c7266d5f9e Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c9c029507f80b31fb67b1b545f3062c7266d5f9e commit c9c029507f80b31fb67b1b545f3062c7266d5f9e Author: Mark Johnston AuthorDate: 2023-10-23 16:25:20 +0000 Commit: Mark Johnston CommitDate: 2023-10-25 14:27:27 +0000 makefs/zfs: Update dd_used_breakdown after writing the MOS Fixes: 96092bf9108c ("makefs/zfs: Fill out dd_used_breakdown fields in DSL directories") Sponsored by: The FreeBSD Foundation --- usr.sbin/makefs/zfs/dsl.c | 18 ++++++++++++++++-- usr.sbin/makefs/zfs/objset.c | 3 +-- usr.sbin/makefs/zfs/zfs.h | 2 +- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/usr.sbin/makefs/zfs/dsl.c b/usr.sbin/makefs/zfs/dsl.c index f7abebe2e245..93083f286e81 100644 --- a/usr.sbin/makefs/zfs/dsl.c +++ b/usr.sbin/makefs/zfs/dsl.c @@ -423,7 +423,7 @@ dsl_dir_alloc(zfs_opt_t *zfs, const char *name) return (dir); } -void +static void dsl_dir_size_add(zfs_dsl_dir_t *dir, uint64_t bytes) { dir->phys->dd_used_bytes += bytes; @@ -431,6 +431,19 @@ dsl_dir_size_add(zfs_dsl_dir_t *dir, uint64_t bytes) dir->phys->dd_uncompressed_bytes += bytes; } +/* + * See dsl_dir_root_finalize(). + */ +void +dsl_dir_root_finalize(zfs_opt_t *zfs, uint64_t bytes) +{ + dsl_dir_size_add(zfs->mosdsldir, bytes); + zfs->mosdsldir->phys->dd_used_breakdown[DD_USED_HEAD] += bytes; + + dsl_dir_size_add(zfs->rootdsldir, bytes); + zfs->rootdsldir->phys->dd_used_breakdown[DD_USED_CHILD] += bytes; +} + /* * Convert dataset properties into entries in the DSL directory's properties * ZAP. @@ -520,7 +533,8 @@ dsl_dir_finalize(zfs_opt_t *zfs, zfs_dsl_dir_t *dir, void *arg __unused) * The root directory needs a special case: the amount of * space used for the MOS isn't known until everything else is * finalized, so it can't be accounted in the MOS directory's - * parent until then. + * parent until then, at which point dsl_dir_root_finalize() is + * called. */ if (dir == zfs->rootdsldir && cdir == zfs->mosdsldir) continue; diff --git a/usr.sbin/makefs/zfs/objset.c b/usr.sbin/makefs/zfs/objset.c index 3e3dcdeced4b..6be732db477a 100644 --- a/usr.sbin/makefs/zfs/objset.c +++ b/usr.sbin/makefs/zfs/objset.c @@ -185,8 +185,7 @@ objset_write(zfs_opt_t *zfs, zfs_objset_t *os) * We've finished allocating space, account for it in $MOS and * in the parent directory. */ - dsl_dir_size_add(zfs->mosdsldir, os->space); - dsl_dir_size_add(zfs->rootdsldir, os->space); + dsl_dir_root_finalize(zfs, os->space); } _objset_write(zfs, os, c, dnodeloc); } diff --git a/usr.sbin/makefs/zfs/zfs.h b/usr.sbin/makefs/zfs/zfs.h index 193ca1248d89..9af090b14912 100644 --- a/usr.sbin/makefs/zfs/zfs.h +++ b/usr.sbin/makefs/zfs/zfs.h @@ -124,7 +124,7 @@ char *dsl_dir_get_mountpoint(zfs_opt_t *, zfs_dsl_dir_t *); bool dsl_dir_has_dataset(zfs_dsl_dir_t *); bool dsl_dir_dataset_has_objset(zfs_dsl_dir_t *); void dsl_dir_dataset_write(zfs_opt_t *, zfs_objset_t *, zfs_dsl_dir_t *); -void dsl_dir_size_add(zfs_dsl_dir_t *, uint64_t); +void dsl_dir_root_finalize(zfs_opt_t *, uint64_t); void dsl_write(zfs_opt_t *); /* fs.c */