Date: Wed, 21 Apr 2021 04:57:40 GMT From: Tobias Kortkamp <tobik@FreeBSD.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: git: 12837690ed0c - main - Mk/Uses/cabal.mk: Replace shell process in EXECUTABLES wrapper scripts Message-ID: <202104210457.13L4ve1D077991@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by tobik: URL: https://cgit.FreeBSD.org/ports/commit/?id=12837690ed0c7785f94e8793ddc13a57477ef319 commit 12837690ed0c7785f94e8793ddc13a57477ef319 Author: Tobias Kortkamp <tobik@FreeBSD.org> AuthorDate: 2021-04-21 04:34:56 +0000 Commit: Tobias Kortkamp <tobik@FreeBSD.org> CommitDate: 2021-04-21 04:46:41 +0000 Mk/Uses/cabal.mk: Replace shell process in EXECUTABLES wrapper scripts The wrapper scripts leave the shell running for no reason. Add an exec to replace the shell process. Before: $ ps -d 35230 5 Ss 0:00.09 -oksh (oksh) 35351 5 S+ 0:00.00 - /bin/sh /usr/local/bin/shellcheck - 35352 5 S+ 0:00.00 `-- /usr/local/libexec/cabal/shellcheck - After: $ ps -d 35230 5 Is 0:00.05 -oksh (oksh) 35236 5 I+ 0:00.01 - /usr/local/libexec/cabal/shellcheck - Approved by: arrowd Differential Revision: https://reviews.freebsd.org/D29852 --- Mk/Uses/cabal.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Mk/Uses/cabal.mk b/Mk/Uses/cabal.mk index 78a8acb271cb..45ee43883ef6 100644 --- a/Mk/Uses/cabal.mk +++ b/Mk/Uses/cabal.mk @@ -196,7 +196,7 @@ do-install: ${ECHO_CMD} 'export ${dep:S/-/_/}_datadir=${DATADIR}' >> ${STAGEDIR}${PREFIX}/bin/${exe} . endfor ${ECHO_CMD} '' >> ${STAGEDIR}${PREFIX}/bin/${exe} - ${ECHO_CMD} '${PREFIX}/${CABAL_LIBEXEC}/${exe} "$$@"' >> ${STAGEDIR}${PREFIX}/bin/${exe} + ${ECHO_CMD} 'exec ${PREFIX}/${CABAL_LIBEXEC}/${exe} "$$@"' >> ${STAGEDIR}${PREFIX}/bin/${exe} ${CHMOD} +x ${STAGEDIR}${PREFIX}/bin/${exe} . endfor . endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104210457.13L4ve1D077991>