From owner-freebsd-net@FreeBSD.ORG Tue Nov 29 23:03:01 2011 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D066A106564A; Tue, 29 Nov 2011 23:03:01 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7E42E8FC12; Tue, 29 Nov 2011 23:03:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pATN31wb062455; Tue, 29 Nov 2011 23:03:01 GMT (envelope-from yongari@freefall.freebsd.org) Received: (from yongari@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pATN30W7062450; Tue, 29 Nov 2011 23:03:00 GMT (envelope-from yongari) Date: Tue, 29 Nov 2011 23:03:00 GMT Message-Id: <201111292303.pATN30W7062450@freefall.freebsd.org> To: pmc@citylink.dinoex.sub.org, yongari@FreeBSD.org, freebsd-net@FreeBSD.org, yongari@FreeBSD.org From: yongari@FreeBSD.org Cc: Subject: Re: kern/162932: [ed][panic][patch] large traffic yields occasional panics X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2011 23:03:01 -0000 Synopsis: [ed][panic][patch] large traffic yields occasional panics State-Changed-From-To: open->feedback State-Changed-By: yongari State-Changed-When: Tue Nov 29 23:01:36 UTC 2011 State-Changed-Why: It seems that the code path referenced invalid address when a mbuf length is odd bytes. I created a new diff based on your patch since your patch may still invoke bus_space_write_1(9) if mbuf length is even bytes. I also added mbuf length check and used NULL in comparing a mbuf pointer. You can find the patch at the following URL. http://people.freebsd.org/~yongari/ed.pf.diff Let me know whether this patch works for you. Responsible-Changed-From-To: freebsd-net->yongari Responsible-Changed-By: yongari Responsible-Changed-When: Tue Nov 29 23:01:36 UTC 2011 Responsible-Changed-Why: Grab. http://www.freebsd.org/cgi/query-pr.cgi?pr=162932