From owner-svn-src-head@freebsd.org Sat Jan 14 03:50:31 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C087CAEA5C; Sat, 14 Jan 2017 03:50:31 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C92D01A85; Sat, 14 Jan 2017 03:50:30 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f68.google.com with SMTP id l2so16083131wml.2; Fri, 13 Jan 2017 19:50:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=IkxXkYWnZf6HDwhA/IL5MWaOVlO3bqy9+2Tds24WA/Y=; b=GjuA/UpmFVb8/2aysAZEFsWjRZIAu/jPKFkOWD8uPOYkqzxnrQWM3OdAhHnLJc5VQR ZqrGLpNrHE4JciqcTdEVXVtzqFZ8AfymGMpOiBpF0r9ygDL2dwwYznOiAeY0rDZX3jv9 Fz54cxjrDpmx9tnZVXpVLBJCHzD+bo4P6h3aUMEMJe4QeXKGV6cuKGTXb6yleAVzeQA0 mPLHc5t6md6Z/0HUydakhj+GeoLDp8BMtE+r78VGh3cInHFxahPDI2Y/Va9of/8UZjhY jLjzeULuzG3kXahcsS7kCdk4x8KQifSFJOkFdXG9B3raR5GCBmTYi5uyU/SVcH8nD+16 K7og== X-Gm-Message-State: AIkVDXJQJav+1ISVkYWzYMG5sAn+79XrG0ao3fG8kXWPUIRyaQr0boQBmOtSX5hhrYbMWA== X-Received: by 10.223.171.141 with SMTP id s13mr55707wrc.23.1484365823076; Fri, 13 Jan 2017 19:50:23 -0800 (PST) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com. [74.125.82.53]) by smtp.gmail.com with ESMTPSA id u81sm9086258wmu.10.2017.01.13.19.50.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jan 2017 19:50:22 -0800 (PST) Received: by mail-wm0-f53.google.com with SMTP id c85so89661027wmi.1; Fri, 13 Jan 2017 19:50:22 -0800 (PST) X-Received: by 10.28.6.210 with SMTP id 201mr4794665wmg.85.1484365822219; Fri, 13 Jan 2017 19:50:22 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.194.29.72 with HTTP; Fri, 13 Jan 2017 19:50:21 -0800 (PST) In-Reply-To: <201701140239.v0E2doD2069898@slippy.cwsent.com> References: <201701140103.v0E13K8b068874@repo.freebsd.org> <201701140239.v0E2doD2069898@slippy.cwsent.com> From: Conrad Meyer Date: Fri, 13 Jan 2017 19:50:21 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r312103 - head/tests/sys/vfs To: Cy Schubert Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2017 03:50:31 -0000 Hi Cy, r312107 fixes it. If the warning-cleanups and major changes were committed separately, the more major changes could then have been reverted independently. Unfortunately, they were not. The warnings are harmless, though, so just turning them down again is fine. Best, Conrad On Fri, Jan 13, 2017 at 6:39 PM, Cy Schubert wrote: > In message <201701140103.v0E13K8b068874@repo.freebsd.org>, "Conrad E. > Meyer" wr > ites: >> Author: cem >> Date: Sat Jan 14 01:03:20 2017 >> New Revision: 312103 >> URL: https://svnweb.freebsd.org/changeset/base/312103 >> >> Log: >> Revert r310994 >> >> Don't implement some terrible hack on a test by test basis. The >> framework fix is straightforward and can be chased up in the original >> bug. >> >> Reviewed by: ngie ("be my guest") >> >> Modified: >> head/tests/sys/vfs/lookup_cap_dotdot.c >> >> Modified: head/tests/sys/vfs/lookup_cap_dotdot.c >> ============================================================================= >> = >> --- head/tests/sys/vfs/lookup_cap_dotdot.c Sat Jan 14 01:01:02 2017 >> (r312102) >> +++ head/tests/sys/vfs/lookup_cap_dotdot.c Sat Jan 14 01:03:20 2017 >> (r312103) >> @@ -31,27 +31,23 @@ __FBSDID("$FreeBSD$"); >> #include >> #include >> #include >> -#include >> >> #include >> -#include >> #include >> #include >> #include >> >> #include "freebsd_test_suite/macros.h" >> >> -static char *abspath; >> -static int dirfd = -1; >> - >> -typedef void (*child_test_fn_t)(void); >> +static int dirfd = -1; >> +static char *abspath; >> >> static void >> -touchat(int _dirfd, const char *name) >> +touchat(int dirfd, const char *name) > > Buildworld is busted right here. It's probably best to leave the underbar > here and in the ATF_REQIRE below. > >> { >> int fd; >> >> - ATF_REQUIRE((fd = openat(_dirfd, name, O_CREAT | O_TRUNC | O_WRONLY, >> + ATF_REQUIRE((fd = openat(dirfd, name, O_CREAT | O_TRUNC | O_WRONLY, > > Here too. > >> 0777)) >= 0); >> ATF_REQUIRE(close(fd) == 0); >> } > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > >