Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Aug 2012 09:20:38 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Wojciech Puchar <wojtek@wojtek.tensor.gdynia.pl>
Cc:        freebsd-hackers@freebsd.org, Mitya <mitya@cabletv.dp.ua>, freebsd-net@freebsd.org
Subject:   Re: Replace bcopy() to update ether_addr
Message-ID:  <420BA06C-C776-47DB-B3BB-F1414C115F99@bsdimp.com>
In-Reply-To: <alpine.BSF.2.00.1208210942150.33814@wojtek.tensor.gdynia.pl>
References:  <50324DB4.6080905@cabletv.dp.ua> <alpine.BSF.2.00.1208201844220.35173@wojtek.tensor.gdynia.pl> <B2BB7724-57A9-40C9-AE9F-FFEC83D9DE9A@bsdimp.com> <alpine.BSF.2.00.1208202117230.19372@wojtek.tensor.gdynia.pl> <5452BF37-3658-4C1F-B965-CE3EA28B6EA5@bsdimp.com> <alpine.BSF.2.00.1208210942150.33814@wojtek.tensor.gdynia.pl>

next in thread | previous in thread | raw e-mail | index | archive | help

On Aug 21, 2012, at 1:42 AM, Wojciech Puchar wrote:

>>=20
>> Even without this tagging, the code to do a structure level copy of 6 =
bytes is going to be tiny...
>=20
> true.
>=20
> just to make sure it will be absolutely portable how about
>=20
> bcopymacaddress(dst,src)
>=20
> and then define it whatever you find it fastest on any architecture?

How about just changing it to the *dst =3D *src, compiling it on all =
architectures and then deciding if the improvement of the code from a =
hand-tweaked thing is worth that uglification?

Warner




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?420BA06C-C776-47DB-B3BB-F1414C115F99>