From owner-freebsd-current@freebsd.org Tue Jan 19 17:20:02 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E559DA86580 for ; Tue, 19 Jan 2016 17:20:01 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C720717F6 for ; Tue, 19 Jan 2016 17:20:01 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: by mailman.ysv.freebsd.org (Postfix) id C3D41A8657E; Tue, 19 Jan 2016 17:20:01 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAAEFA8657C for ; Tue, 19 Jan 2016 17:20:01 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm43-vm5.bullet.mail.gq1.yahoo.com (nm43-vm5.bullet.mail.gq1.yahoo.com [67.195.87.220]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7188017F5 for ; Tue, 19 Jan 2016 17:20:01 +0000 (UTC) (envelope-from scott4long@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1453223618; bh=U8yG3IpWN4ie+PyrYQU3nDZa+4DZUEGe1+IY7/loVNo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject; b=RJIbnmay/tI+J2qJgNLsKSq0C5IBHURpJKMc8CbmX6sJ0ZSS1FTTR7bRehXfuXoHOuHMHSa4e8Y2s80FIQWhlqlp0qoMHMTNFX3rFT1T13BfomAPMZVDnj/Ca4naNEI8YjQF8GsrnIpKRwXCr8LM7g14hjDh3n49I6LsiHqGqW/93tT3NeufmSm9GEnWtq58+emQe++2kbSTQ1iWrJeQw9PH5MTq0mavR61Sbr7WObHG3PGNgWPKf/jPU5VGEC8TjZ47FKcY9JTK8H3KDo59sNDLgC8k7VYOsWdnpFYDYiJ1L5LXpIjbH4QQ0tQAI/Ium501OGk0yQLLLwqenm9wyQ== Received: from [127.0.0.1] by nm43.bullet.mail.gq1.yahoo.com with NNFMP; 19 Jan 2016 17:13:38 -0000 Received: from [98.137.12.57] by nm43.bullet.mail.gq1.yahoo.com with NNFMP; 19 Jan 2016 17:10:51 -0000 Received: from [98.136.164.78] by tm2.bullet.mail.gq1.yahoo.com with NNFMP; 19 Jan 2016 17:10:51 -0000 Received: from [127.0.0.1] by smtp240.mail.gq1.yahoo.com with NNFMP; 19 Jan 2016 17:10:51 -0000 X-Yahoo-Newman-Id: 762227.92472.bm@smtp240.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-4 X-YMail-OSG: SUv.dT4VM1miuUV9Jva.u5fdfRVO3UeJqZTEFFvRqlT9BDz 2pMwid5EApaVaSOEUNzUr8nB0.Fu6g1V5DQMbasAb8_TQLFmnF84s5IE3TQl fadHcDogXiZUzHWaBW.dYz_oY88rHWjAoBZYA.RD78RvbFu0yvxnP2kvGqmL hZNw6Cgj8EcfrWGiMMfACzUAKDpbfoSgRKTdy2xVMpoPTDfVKxKN0kH2wVE6 wFg3LBMp8jGLY9HOMPd0p.BkaX3QwubMpmjA.3uRWanZ_pvjk4X6Oin03xG5 98WtH2W8tJbZgoiyZtIm6t2KkueB_8jawtE0q2FCprSRc6JxJ0ZB29wWjZLb ekFOOqPpJBEDYhBxlLU2N90gp6JmPgQmWrq2yTJrR9j6NxGd9p.rfA5P4Grb F115OYjDI8eG_7Vzrbwf9qxT_kiAU4N_dZcv0gemLgetnuUs6uWdnp_uYIxo 2.3pd0PV5e8ErB2Lhvvh9g13sPCtnTR.PD14FZdx8ZbGalFyIYbtGQ4VT0o8 63Ozmw1P_B2DYEbl5itV54fM921X.lNSzNkr0o5hit7dUW5Kux9p9 X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: CAM Shingled Disk support patches available From: Scott Long In-Reply-To: <20160119162555.GA99885@mithlond.kdm.org> Date: Tue, 19 Jan 2016 09:10:48 -0800 Cc: Warner Losh , current@freebsd.org, scsi@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <07A5702E-86FB-488C-92E8-850457DD8C17@yahoo.com> References: <20151118171309.GA3564@mithlond.kdm.org> <20160118223704.GA87506@mithlond.kdm.org> <349FCA2B-8346-4EC2-8459-B174FDC2CDB3@bsdimp.com> <20160119162555.GA99885@mithlond.kdm.org> To: "Kenneth D. Merry" X-Mailer: Apple Mail (2.3112) X-Mailman-Approved-At: Tue, 19 Jan 2016 18:27:37 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2016 17:20:02 -0000 > On Jan 19, 2016, at 8:25 AM, Kenneth D. Merry wrote: >=20 >=20 >>> In the ada(4) case, we need to add the register to struct ccb_ataio = and >>> add support in one or more of the underlying SATA drivers, e.g. = ahci(4). >>=20 >> I believe that changes the size of the CCB, so I tried to avoid >> that since I didn???t want to force a recompile of camcontrol(8). >> Adding it to the atacmd structure wasn???t so bad, and the CCB size >> didn???t completely change. The problem was that the atacmd changed >> size and pushed all the other fields. >=20 > Yes. In order to do it, we'll need to add it to struct atacmd, and = add > compatibility shims. I don't see another way to do it unfortunately. >=20 No, I object to changing the structure sizes and contents. It should be = a new CCB, XPT_ATA_IO_EXT, ccb_ataio_ext. If you want to add more future-looking fields than just the AUX register, maybe a way to define un-typed command and response register objects, that=E2=80=99s fine and = probably a good idea. The periph drivers can probe for the proper command to send based on whether the SIM returning CAM_FUNC_NOTAVAIL or via a PIM flag, or even better, via a KVP capability CCB. However I=E2=80=99m = firmly against changing the existing data structures; compat shims have been a pain and are a poor solution. Warner and I are pounding out a proposal for this, will share a diff = shortly. Scott