Date: Wed, 7 Nov 2007 15:24:23 -0600 From: "Jason Harmening" <jason.harmening@gmail.com> To: freebsd-drivers@freebsd.org Subject: iicbus ivars and BUS_ADD_CHILD Message-ID: <2d1264630711071324s32eda7d7j8d12ccff20df900a@mail.gmail.com> In-Reply-To: <2d1264630711061422r4d76480bp7be0a70823388db3@mail.gmail.com> References: <2d1264630711061422r4d76480bp7be0a70823388db3@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi everyone, I've been looking over the 7.0 iicbus code, and I see that the iicbus driver now uses an ivar to store the address for each child device (cool!). The ivar is malloc'ed in the iicbus implementation of BUS_ADD_CHILD, but it doesn't ever appear to be freed. And bus_if.m doesn't appear to contain a reciprocal for BUS_ADD_CHILD (e.g. BUS_DELETE_CHILD) that would take care of bus-specific cleanup. Are ivars just leaked right now when device_delete_child() is called on the child device, or is the caller of device_delete_child() expected to free them? Thanks, Jason
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2d1264630711071324s32eda7d7j8d12ccff20df900a>