From owner-svn-src-head@freebsd.org Sat Jan 13 03:19:44 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0FAD0E6E364; Sat, 13 Jan 2018 03:19:44 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D3E556FED2; Sat, 13 Jan 2018 03:19:43 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (cpe-75-82-218-62.socal.res.rr.com [75.82.218.62]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id w0D39Efo007022 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 12 Jan 2018 19:09:15 -0800 Subject: Re: svn commit: r327907 - in head/sys: conf dev/fdt dev/ofw To: Justin Hibbits , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801130256.w0D2u9fn087029@repo.freebsd.org> From: Nathan Whitehorn Message-ID: Date: Fri, 12 Jan 2018 19:09:13 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <201801130256.w0D2u9fn087029@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVZZAsxCmSbgNHVVbBhZuG7kuiCHjHqsxUgS7Ak2WJlzkROp1E1uECn1+1IgTxdlcV5PO6D6IqioiNpUlqj2ZGi0hZbKGolNF9U= X-Sonic-ID: C;iv9YIg/45xG+juBQ9eIpJw== M;fiXuIg/45xG+juBQ9eIpJw== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 03:19:44 -0000 Thanks, Justin! Since the fixup stuff is now only defined for FDT_MARVELL, it would be great if it could move to sys/arm/mv now instead of being in MI code. -Nathan On 01/12/18 18:56, Justin Hibbits wrote: > Author: jhibbits > Date: Sat Jan 13 02:56:09 2018 > New Revision: 327907 > URL: https://svnweb.freebsd.org/changeset/base/327907 > > Log: > Remove fdt fixups for powerpc, they are no longer needed. > > If a fixup really is needed, it should be fixed in u-boot, not in FreeBSD. > > Suggested by: nwhitehorn > > Deleted: > head/sys/dev/fdt/fdt_powerpc.c > Modified: > head/sys/conf/files.powerpc > head/sys/dev/ofw/ofw_fdt.c > > Modified: head/sys/conf/files.powerpc > ============================================================================== > --- head/sys/conf/files.powerpc Sat Jan 13 01:36:37 2018 (r327906) > +++ head/sys/conf/files.powerpc Sat Jan 13 02:56:09 2018 (r327907) > @@ -31,7 +31,6 @@ dev/adb/adb_if.m optional adb > dev/adb/adb_buttons.c optional adb > dev/agp/agp_apple.c optional agp powermac > dev/fb/fb.c optional sc > -dev/fdt/fdt_powerpc.c optional fdt > # ofwbus depends on simplebus. > dev/fdt/simplebus.c optional aim | fdt > dev/hwpmc/hwpmc_e500.c optional hwpmc > > Modified: head/sys/dev/ofw/ofw_fdt.c > ============================================================================== > --- head/sys/dev/ofw/ofw_fdt.c Sat Jan 13 01:36:37 2018 (r327906) > +++ head/sys/dev/ofw/ofw_fdt.c Sat Jan 13 02:56:09 2018 (r327907) > @@ -430,7 +430,7 @@ ofw_fdt_package_to_path(ofw_t ofw, phandle_t package, > return (-1); > } > > -#if defined(FDT_MARVELL) || defined(__powerpc__) > +#if defined(FDT_MARVELL) > static int > ofw_fdt_fixup(ofw_t ofw) > { > @@ -477,7 +477,7 @@ ofw_fdt_fixup(ofw_t ofw) > static int > ofw_fdt_interpret(ofw_t ofw, const char *cmd, int nret, cell_t *retvals) > { > -#if defined(FDT_MARVELL) || defined(__powerpc__) > +#if defined(FDT_MARVELL) > int rv; > > /* >