From owner-freebsd-net@FreeBSD.ORG Mon Sep 30 21:44:45 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CD3C03B8 for ; Mon, 30 Sep 2013 21:44:45 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-ee0-x232.google.com (mail-ee0-x232.google.com [IPv6:2a00:1450:4013:c00::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 55ABC282C for ; Mon, 30 Sep 2013 21:44:45 +0000 (UTC) Received: by mail-ee0-f50.google.com with SMTP id d51so2944628eek.23 for ; Mon, 30 Sep 2013 14:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=UcLNsMXlSQlGRBSeGaBpYKLRNKvqbHsGM4RbFayL0cU=; b=wRGEgWwpE9MBp1Dzup0+HCpbDZJZYHbrYPc7f65VZq9q8IiK6iW4YNfTwb4aFqzh+0 mv8KtOOEVWj2hbmmFXZ9/01rbjwZGodeNMZV1acdDkGhoF3YSJm1cCngLcK529cjIcXU 1PHlWI2mGkHsN8tdItJWQIDZbh36jFsjOYhCFyZH6uB+KepZRcYW6Tv4LoLaTtC1yppE iW/A611KENvGOOvMdKoB+zLDUaon33QVf0ONRnKoUgR1bSFvOA353fsvKZq4aaIIZYoT tlkJTVmv+Ftea3QyAqFnOKWKYs5tAt0tRhu46gCqqTwgl8bu8tq1OgBINl/2OZ3t8Nke qCDw== MIME-Version: 1.0 X-Received: by 10.15.45.8 with SMTP id a8mr40682658eew.1.1380577483754; Mon, 30 Sep 2013 14:44:43 -0700 (PDT) Received: by 10.14.105.137 with HTTP; Mon, 30 Sep 2013 14:44:43 -0700 (PDT) In-Reply-To: References: Date: Mon, 30 Sep 2013 14:44:43 -0700 Message-ID: Subject: Re: Flow Director statistics for ixgbe(4) From: hiren panchasara To: Takuya ASADA Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: FreeBSD Net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Sep 2013 21:44:45 -0000 On Mon, Sep 30, 2013 at 1:48 PM, Takuya ASADA wrote: > Hi, > > descriptions are added. > Great. My minor suggestions (you can ignore them :-)) from "Number of filters addition events that do not change the number of free" to "Number of failed filter addition events" (I believe, "do not change the number of free" part is given when addition is failing) from "Number of packets that missed matched any flow director filter" to "Number of packets that didn't match any flow director filter" > > 2013/10/1 hiren panchasara > >> >> >> >> On Mon, Sep 30, 2013 at 12:02 PM, Takuya ASADA wrote: >> >>> Hi, >>> >>> This is originally part of "ixgbetool" patch, but I think it can be >>> discuss >>> separately: >>> >>> http://freebsd.1045724.n5.nabble.com/Adding-Flow-Director-sysctls-to-ixgbe-4-was-netmap-traffic-distribution-tp5847066p5847789.html >>> >>> I implemented sysctls to expose Flow Director statistics. >>> It works like this: >>> $ sysctl dev.ix.0.mac_stats|grep fdir >>> dev.ix.0.mac_stats.fdirfree_free: 8192 >>> dev.ix.0.mac_stats.fdirfree_coll: 0 >>> dev.ix.0.mac_stats.fdirustat_add: 0 >>> dev.ix.0.mac_stats.fdirustat_remove: 0 >>> dev.ix.0.mac_stats.fdirfstat_fadd: 0 >>> dev.ix.0.mac_stats.fdirfstat_fremove: 0 >>> dev.ix.0.mac_stats.fdirmatch: 0 >>> dev.ix.0.mac_stats.fdirmiss: 23 >>> >> >> I am running this with the ixgbetool patch you have and only 1 issue I've >> seen so far: fdirustat_add increments on adding a filter but >> fdirustat_remove does not on deleting one (if thats how its supposed to >> work) >> > As we talked on another thread, yes, problem is just the counter not getting updated. The functionality is fine. Appreciate your awesome work. Cheers, Hiren