From owner-svn-src-all@freebsd.org Wed Apr 27 17:24:00 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDD64B1E4EC; Wed, 27 Apr 2016 17:24:00 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9EF78107C; Wed, 27 Apr 2016 17:24:00 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B22BCB93C; Wed, 27 Apr 2016 13:23:59 -0400 (EDT) From: John Baldwin To: Zbigniew Bodek Cc: =?utf-8?B?TWljaGHFgg==?= Stanek , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298425 - head/sys/dev/acpica Date: Wed, 27 Apr 2016 09:46:35 -0700 Message-ID: <32556581.Dd6EY0QH0C@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: References: <201604211827.u3LIR5ML089177@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 27 Apr 2016 13:23:59 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2016 17:24:00 -0000 On Wednesday, April 27, 2016 04:57:28 PM Zbigniew Bodek wrote: > Hello, > > I'm forwarding a message from Michal Stanek who found some problems wit > this commit. Please see below: It looks like you have "cpuX" devices that aren't acpi_cpu.c devices. That's fine, but that is why this driver is confused a bit. Before my change all that happened was that this triggered extra probe/attach of child devices, but now it queues the ACPI-specific task as well. I've add you to a review for a change I think will fix this (and which I've tested on amd64 with ACPI): https://reviews.freebsd.org/D6133 -- John Baldwin