From owner-svn-src-head@FreeBSD.ORG Fri May 22 18:50:51 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D42501065672; Fri, 22 May 2009 18:50:51 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id A54448FC23; Fri, 22 May 2009 18:50:51 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n4MIopUD075768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 May 2009 11:50:51 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <4A16F40B.4020404@freebsd.org> Date: Fri, 22 May 2009 11:50:51 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.21 (X11/20090411) MIME-Version: 1.0 To: Alexey Dokuchaev References: <200905221810.n4MIAe4J014419@svn.freebsd.org> <20090522184846.GA34437@FreeBSD.org> In-Reply-To: <20090522184846.GA34437@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-x.dcc-servers-Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, Rick Macklem , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r192591 - head/sys/fs/nfsserver X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2009 18:50:52 -0000 Alexey Dokuchaev wrote: > On Fri, May 22, 2009 at 06:10:40PM +0000, Rick Macklem wrote: > >> Author: rmacklem >> Date: Fri May 22 18:10:39 2009 >> New Revision: 192591 >> URL: http://svn.freebsd.org/changeset/base/192591 >> >> Log: >> Modified the printf message of r192590 to remove the >> possible DOS attack, as suggested by Sam. >> >> - printf("out of clientids, possible DOS attack\n"); >> + printf("out of clientids\n"); >> > > Previously, panic() message referred "nfs4", now it does not, making it > rather cryptic without grepping through the source code. > > . I requested the printf identify the call site; e.g. printf("%s: out of clientids\n", __func__);