From owner-freebsd-arch  Sat Oct  6  5:27:37 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP id 69E8737B403
	for <arch@FreeBSD.ORG>; Sat,  6 Oct 2001 05:27:34 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA32096;
	Sat, 6 Oct 2001 22:27:25 +1000
Date: Sat, 6 Oct 2001 22:26:45 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@delplex.bde.org>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: Peter Wemm <peter@wemm.org>, <arch@FreeBSD.ORG>
Subject: Re: Removing ptrace(2)'s dependency on procfs(5)
In-Reply-To: <xzpzo76ry1w.fsf@flood.ping.uio.no>
Message-ID: <20011006221156.X824-100000@delplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

On 5 Oct 2001, Dag-Erling Smorgrav wrote:

> Dag-Erling Smorgrav <des@ofug.org> writes:
> > I've put up a new patch that places the prototypes in ptrace.h rather
> > than add a new header:

They don't belong in ptrace.h either, since they are used by both procfs
and ptrace.

> I left one instance of #include <sys/debug.h> in, so this patch
> wouldn't build.  The correct (and tested) patch is:
>
>     http://people.freebsd.org/~des/software/ptrace-20011005b.diff

Please include things that you want reviewed in mail unless they are
large (100K+ or so).

I noticed the following bugs:
- PHOLD()/PRELE() is now missing from the register access functions of
  ptrace().  This makes the bogus EIO error in PROCFS_ACTION() much less
  unlikely.
- there is lots of gratuitous breakage of K&R support.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message