From owner-svn-src-head@FreeBSD.ORG Tue Dec 1 00:32:41 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C08D106566B; Tue, 1 Dec 2009 00:32:41 +0000 (UTC) (envelope-from lynx.ripe@gmail.com) Received: from mail-fx0-f218.google.com (mail-fx0-f218.google.com [209.85.220.218]) by mx1.freebsd.org (Postfix) with ESMTP id 4D27B8FC1B; Tue, 1 Dec 2009 00:32:39 +0000 (UTC) Received: by fxm10 with SMTP id 10so3647638fxm.14 for ; Mon, 30 Nov 2009 16:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=lxkgGsdTXtz9qnm+rb3GJQ9Ge8bLQY5aoedkBw05y2g=; b=H+kxDtqFm9Wyb03F1FTnVhNJYz5TH52xwoIoDgFh+BS0O3LTP6JW4mi2cO2oLMvaOY LUTnCteCnLxwdYSfvKcntH44q55LC+2WojHUidneYV352nxUG8st2arBrMKs6tv0zhLN nkekqhdukTulNVGj+evHpPwfOVNDK0fVzpa8A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=ssuwhZNKRoNT7gFMEbdzQS18ysJJgedzObJWodMrrwbpcoFsCZ3TIFO4+6zGS21Pjn MOXwtmd5IlGHjNxS2xRaCUdsETGACWP8/K17YaxzUKuGE3ckQPDqXTK2Q7j+kES69Z11 6VDkpggdv/03zAjDnxz+YRaDL9oIrjC6Gt+6E= Received: by 10.86.161.1 with SMTP id j1mr4808623fge.7.1259627558093; Mon, 30 Nov 2009 16:32:38 -0800 (PST) Received: from lynx.homenet (135-4-132-95.pool.ukrtel.net [95.132.4.135]) by mx.google.com with ESMTPS id 12sm12190742fgg.2.2009.11.30.16.32.36 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 30 Nov 2009 16:32:37 -0800 (PST) Message-ID: <4B146423.2090703@gmail.com> Date: Tue, 01 Dec 2009 02:32:35 +0200 From: Dmitry Pryanishnikov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.23) Gecko/20090906 SeaMonkey/1.1.18 MIME-Version: 1.0 To: Brooks Davis Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195843 - in head: lib/libkvm sys/kern sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2009 00:32:41 -0000 Hello! > Author: brooks > Date: Fri Jul 24 15:03:10 2009 > New Revision: 195843 > URL: http://svn.freebsd.org/changeset/base/195843 > > Log: > Revert the changes to struct kinfo_proc in r194498. Instead, fill > in up to 16 (KI_NGROUPS) values and steal a bit from ki_cr_flags > (all bits currently unused) to indicate overflow with the new flag > KI_CRF_GRP_OVERFLOW. > > This fixes procstat -s. > > Approved by: re (kib) > > Modified: > head/lib/libkvm/kvm_proc.c > head/sys/kern/kern_proc.c > head/sys/sys/user.h > > Modified: head/lib/libkvm/kvm_proc.c > ============================================================================== > --- head/lib/libkvm/kvm_proc.c Fri Jul 24 14:57:02 2009 (r195842) > +++ head/lib/libkvm/kvm_proc.c Fri Jul 24 15:03:10 2009 (r195843) > @@ -145,8 +145,14 @@ kvm_proclist(kd, what, arg, p, bp, maxcn > kp->ki_svuid = ucred.cr_svuid; > kp->ki_rgid = ucred.cr_rgid; > kp->ki_svgid = ucred.cr_svgid; > - kp->ki_ngroups = ucred.cr_ngroups; > - kp->ki_groups = ucred.cr_groups; > + kp->ki_cr_flags = ucred.cr_flags; > + if (ucred.cr_ngroups > KI_NGROUPS) { > + kp->ki_ngroups = KI_NGROUPS; > + kp->ki_cr_flags |= KI_CRF_GRP_OVERFLOW; > + } > + kp->ki_ngroups = ucred.cr_ngroups; It seems that 'else' is missing after closing brace of this 'if'? With the code as is, 'kp->ki_ngroups = KI_NGROUPS;' is effectively NO-OP... Sincerely, Dmitry -- nic-hdl: LYNX-RIPE