From owner-svn-src-head@freebsd.org  Sun Dec 24 09:11:05 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CAADEA7C22
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun, 24 Dec 2017 09:11:05 +0000 (UTC) (envelope-from
 0100016087ca1b46-38e5e938-0fa6-4fb5-b571-7a8ef00f34cc-000000@amazonses.com)
Received: from a8-176.smtp-out.amazonses.com (a8-176.smtp-out.amazonses.com
 [54.240.8.176])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 61EC270281
 for <svn-src-head@freebsd.org>; Sun, 24 Dec 2017 09:11:04 +0000 (UTC)
 (envelope-from
 0100016087ca1b46-38e5e938-0fa6-4fb5-b571-7a8ef00f34cc-000000@amazonses.com)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple;
 s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn; d=tarsnap.com; t=1514106657;
 h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
 bh=jtk5PAnadJ/gvAecymUZ8A4CNnpHTHGuMCkmarYIf6A=;
 b=npLmdnWMbkg710/k8BYNpNRpv8yIcwyire9R9KW3BjIs4rPCHy22davmZ2glwd2I
 EhODUzpKYdcNhhdmczUVGxHPaM2AddCLFn16y47uYw/1CSxmLES08rYCS3Ysw9Fy9O6
 SjMaH8hTooNpIi7Gr2RHI2Z7U1k2/G3O6A9ARcrI=
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple;
 s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1514106657;
 h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID;
 bh=jtk5PAnadJ/gvAecymUZ8A4CNnpHTHGuMCkmarYIf6A=;
 b=Lj5Zz4vY8DriON8/IDQAyhfqjV+IrK+kvQFrlwuQFgafbf1nNLHN+UDpaPzXHnYA
 5/wfJFX2focqY9WmDlqOkFtvqOgEKeQpzeCWqSLrRTCex+onoEJ5fW5E6cgjJL8h5zD
 QO/wbNzgH+pwZJVNz6N0pZ0T4nMjbS71WYlp6ms4=
Subject: Re: svn commit: r327120 - in head/sys: isa x86/isa
To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201712232257.vBNMvEHk023093@repo.freebsd.org>
From: Colin Percival <cperciva@tarsnap.com>
Message-ID: <0100016087ca1b46-38e5e938-0fa6-4fb5-b571-7a8ef00f34cc-000000@email.amazonses.com>
Date: Sun, 24 Dec 2017 09:10:57 +0000
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <201712232257.vBNMvEHk023093@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SES-Outgoing: 2017.12.24-54.240.8.176
Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2017 09:11:05 -0000

On 12/23/17 14:57, Warner Losh wrote:
> -		device_probe_and_attach(child);
> +		err = device_probe_and_attach(child);
> +		if (err == 0 && idev->id_vendorid == 0 &&
> +		    strcmp(kern_ident, "GENERIC") == 0)
> +			device_printf(child,
> +			    "non-PNP ISA device will be removed from GENERIC in FreeBSD 12.");

Maybe worth making this strncmp(kern_ident, "GENERIC", 7) so that it will
catch GENERIC-NODEBUG as well?

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid