From owner-svn-src-all@FreeBSD.ORG Fri Jan 14 21:09:01 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C16821065672; Fri, 14 Jan 2011 21:09:01 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id B05438FC12; Fri, 14 Jan 2011 21:09:01 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p0EL91kD001150; Fri, 14 Jan 2011 21:09:01 GMT (envelope-from jkim@svn.freebsd.org) Received: (from jkim@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p0EL91fD001147; Fri, 14 Jan 2011 21:09:01 GMT (envelope-from jkim@svn.freebsd.org) Message-Id: <201101142109.p0EL91fD001147@svn.freebsd.org> From: Jung-uk Kim Date: Fri, 14 Jan 2011 21:09:01 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r217424 - in head/sys/amd64: ia32 linux32 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2011 21:09:01 -0000 Author: jkim Date: Fri Jan 14 21:09:01 2011 New Revision: 217424 URL: http://svn.freebsd.org/changeset/base/217424 Log: Remove redundant, bogus, and even harmful uses of setting TS bit in CR0. It is done from fpstate_drop() when it is really necessary. Reviewed by: kib MFC after: 1 week Modified: head/sys/amd64/ia32/ia32_signal.c head/sys/amd64/linux32/linux32_sysvec.c Modified: head/sys/amd64/ia32/ia32_signal.c ============================================================================== --- head/sys/amd64/ia32/ia32_signal.c Fri Jan 14 20:43:24 2011 (r217423) +++ head/sys/amd64/ia32/ia32_signal.c Fri Jan 14 21:09:01 2011 (r217424) @@ -741,7 +741,6 @@ ia32_setregs(struct thread *td, struct i regs->tf_gs = _ugssel; regs->tf_flags = TF_HASSEGS; - load_cr0(rcr0() | CR0_MP | CR0_TS); fpstate_drop(td); /* Return via doreti so that we can change to a different %cs */ Modified: head/sys/amd64/linux32/linux32_sysvec.c ============================================================================== --- head/sys/amd64/linux32/linux32_sysvec.c Fri Jan 14 20:43:24 2011 (r217423) +++ head/sys/amd64/linux32/linux32_sysvec.c Fri Jan 14 21:09:01 2011 (r217424) @@ -865,7 +865,7 @@ exec_linux_setregs(struct thread *td, st regs->tf_flags = TF_HASSEGS; regs->tf_cs = _ucode32sel; regs->tf_rbx = imgp->ps_strings; - load_cr0(rcr0() | CR0_MP | CR0_TS); + fpstate_drop(td); /* Do full restore on return so that we can change to a different %cs */