From owner-freebsd-audit  Thu May 10  2: 6:33 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP id 0E9D337B423
	for <audit@FreeBSD.ORG>; Thu, 10 May 2001 02:06:30 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA23633;
	Thu, 10 May 2001 19:06:16 +1000
Date: Thu, 10 May 2001 19:04:45 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Warner Losh <imp@harmony.village.org>
Cc: Dima Dorfman <dima@unixfreak.org>, audit@FreeBSD.ORG
Subject: Re: jot(1) patch 
In-Reply-To: <200105092127.f49LR7b40095@harmony.village.org>
Message-ID: <Pine.BSF.4.21.0105101858240.1351-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Wed, 9 May 2001, Warner Losh wrote:

> In message <20010509210433.1BDA13E28@bazooka.unixfreak.org> Dima Dorfman writes:
> : 	- use getopt
> : 	- de-register
> 
> You should de __P() as well.  The changes add a prototype
> 
> : -usage()
> : +usage(void)
> 
> which breaks K&R compatibility.  So do one or the other.  The one
> thing worse than old K&R code in the tree is broken K&R code in the
> tree.

You should just not gratuitously break usage().  usage() is already
declared to take a void in its forward declaration using __P(()),
so using "void" in its definition just breaks K&R support.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message