From owner-cvs-all Thu Sep 12 11: 1:24 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A923437B400 for ; Thu, 12 Sep 2002 11:01:19 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id E670443E42 for ; Thu, 12 Sep 2002 11:01:18 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 24651 invoked by uid 1000); 12 Sep 2002 18:01:19 -0000 Date: Thu, 12 Sep 2002 11:01:19 -0700 (PDT) From: Nate Lawson To: Thomas Quinot Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata atapi-cam.c In-Reply-To: <200209121515.g8CFFYTv076283@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 12 Sep 2002, Thomas Quinot wrote: > thomas 2002/09/12 08:15:34 PDT > > Modified files: > sys/dev/ata atapi-cam.c > Log: > Change a couple of splcam() calls that do not make sense in atapi-cam > (what we want to mask is the ATA interrupts, which run at level splbio), > and add interrupt masking around the statement that modifies the > request queue for a SIM. > > This resolves problems reported by users under heavy ATAPI load. > > Reviewed by: roberto > > Revision Changes Path > 1.8 +5 -3 src/sys/dev/ata/atapi-cam.c Great! It would be nice if the splbio() could be pushed down more and moved to a local lock instead. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message