From owner-freebsd-stable@FreeBSD.ORG Mon Feb 6 19:46:20 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01470106564A for ; Mon, 6 Feb 2012 19:46:20 +0000 (UTC) (envelope-from adams-freebsd@ateamsystems.com) Received: from fss.sandiego.ateamservers.com (fss.sandiego.ateamservers.com [69.55.229.149]) by mx1.freebsd.org (Postfix) with ESMTP id DBB3B8FC0A for ; Mon, 6 Feb 2012 19:46:19 +0000 (UTC) Received: from [192.168.15.220] (unknown [118.175.84.92]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by fss.sandiego.ateamservers.com (Postfix) with ESMTPSA id 7D9B5B9022; Mon, 6 Feb 2012 12:17:13 -0500 (EST) Message-ID: <4F300B1D.9080809@ateamsystems.com> Date: Tue, 07 Feb 2012 00:17:17 +0700 From: Adam Strohl Organization: A-Team Systems User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Konstantin Belousov References: <4F2BD37E.70209@ateamsystems.com> <20120203144848.GX3283@deviant.kiev.zoral.com.ua> In-Reply-To: <20120203144848.GX3283@deviant.kiev.zoral.com.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kirk McKusick , FreeBSD-Stable ML Subject: Re: FreeBSD 9: Group quotas increase but don't decrease automatically X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2012 19:46:20 -0000 On 2/3/2012 21:48, Konstantin Belousov wrote: > This is a bug in +J code (even if you do not use +J). Do you have > softupdates enabled on the volume ? If yes, try the following patch. > > diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c > index 5b4b6b9..ed2db79 100644 > --- a/sys/ufs/ffs/ffs_softdep.c > +++ b/sys/ufs/ffs/ffs_softdep.c > @@ -43,6 +43,7 @@ > __FBSDID("$FreeBSD$"); > > #include "opt_ffs.h" > +#include "opt_quota.h" > #include "opt_ddb.h" > > /* > @@ -6428,7 +6429,7 @@ softdep_setup_freeblocks(ip, length, flags) > } > #ifdef QUOTA > /* Reference the quotas in case the block count is wrong in the end. */ > - quotaref(vp, freeblks->fb_quota); > + quotaref(ITOV(ip), freeblks->fb_quota); > (void) chkdq(ip, -datablocks, NOCRED, 0); > #endif > freeblks->fb_chkcnt = -datablocks; Bingo, this fixes the issue for me! Testing it out on one machine now and will push it out to the others gradually ... thanks!