From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 24 14:00:31 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E2F737B401 for ; Thu, 24 Apr 2003 14:00:31 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BDC343F85 for ; Thu, 24 Apr 2003 14:00:30 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h3OL0UUp068851 for ; Thu, 24 Apr 2003 14:00:30 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h3OL0USv068846; Thu, 24 Apr 2003 14:00:30 -0700 (PDT) Date: Thu, 24 Apr 2003 14:00:30 -0700 (PDT) Message-Id: <200304242100.h3OL0USv068846@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Brian Skrab (by way of Brian Skrab ) Subject: Re: ports/51005: New port of native window decoration for KDE 3 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Brian Skrab List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Apr 2003 21:00:31 -0000 The following reply was made to PR ports/51005; it has been noted by GNATS. From: Brian Skrab (by way of Brian Skrab ) To: Adam Weinberger Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: ports/51005: New port of native window decoration for KDE 3 Date: Thu, 24 Apr 2003 16:57:11 -0400 --Boundary-00=_n+Eq+dssbZSGYfL Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Adam, I'm just checking in to see if you received my previous reply to your port revision message, that I received on the 15th. I just wanted to touch base, since it's been a week. Thanks, ~brian == 04/16/03 11:56 am ======================================= Adam, Thanks for your quick reply to the submission. I believe that I made a very stupid mistake and submitted a previous, un-polished version of the port. I have included the new version, along with your recommended changes with this message. On Tuesday 15 April 2003 10:48 pm, you wrote: > Your port installs both shared libraries and libtool archives. Are you > sure you want the libtool archives installed? If you want both > installed, you must define: > INSTALLS_SHLIB= yes > USE_LIBTOOL= yes I believe that the libtool archives are required. There appear to be corresponding archives in the same location for other window decorations that are installed on the system. I have added the two lines you mention above to the Makefile. > > XA native Acqua-like window decoration for KDE3, with window drop shadows > > by XDavid Sansome. > > Wait. Did David Sansome just develop the window drop shadows, or did he > make the entire application? Your description implies he only made the > drop shadows. I have enhanced the port description to include a little more information about the supported features. Thus, the implication above has been removed. > OK, you have 3 directories listed as files in here. lib/kde3, share/apps > and share/apps/kwin are not files that get installed by the program, so > why do you list them as such? If a directory gets installed by a program > (which this list implies this program does not), they get listed as > @dirrm's. Otherwise, the directories shouldn't appear in this list. Did > you try to uninstall this program yourself? This was a remnant of the quick-and-dirty port that I mistakenly submitted -- duh. As a note, because the directories that this port installs its components into are used by other ports, I used "@unexec rmdir %%PREFIX%%/dir 2>/dev/null || true" in place of @dirrm /dir. Using @dirrm on non-empty directories results in a misleading error message regarding the validity of the packing list. > And, this brings up one other point: this port does not honor ${PREFIX}. Yet again, my earlier attempt rears its ugly head. > I love window decoration ports... I like eyecandy ;;) Please fix these > things so we can add this port! Thank you for taking interest in this port, and for taking the time to wade through my mistakes. I believe that this new version addresses all of the errors that you identified. ~brian --Boundary-00=_n+Eq+dssbZSGYfL Content-Type: text/plain; charset="iso-8859-1"; name="aquaosk.shar" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="aquaosk.shar" # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # aquaosk # aquaosk/Makefile # aquaosk/pkg-descr # aquaosk/pkg-plist # aquaosk/distinfo # echo c - aquaosk mkdir -p aquaosk > /dev/null 2>&1 echo x - aquaosk/Makefile sed 's/^X//' >aquaosk/Makefile << 'END-of-aquaosk/Makefile' X# New ports collection makefile for: aquaosk X# Date created: Wed Apr 14 08:28:56 EDT 2003 X# Whom: Brian Skrab X# X# $FreeBSD$ X# X XPORTNAME= aquaosk XPORTVERSION= 2.0 XCATEGORIES= x11-wm kde XMASTER_SITES= http://www.davidsansome.com/ \ X http://cottage.quynh-and-brian.org/freebsd/ports/distfiles/ X XMAINTAINER= brian@quynh-and-brian.org XCOMMENT= An Acqua-like native window decoration for KDE 3 X XCONFIGURE_ARGS= --prefix=${PREFIX} XINSTALLS_SHLIB= yes XUSE_LIBTOOL= yes XUSE_KDEBASE_VER=3 XUSE_BZIP2= yes X X.include END-of-aquaosk/Makefile echo x - aquaosk/pkg-descr sed 's/^X//' >aquaosk/pkg-descr << 'END-of-aquaosk/pkg-descr' XA native Acqua-like window decoration for KDE 3, by David Sansome. X XFeatures: X X * Mac OS X style drop shadows for windows. X * Rounded title bar corners. X * Application icon in title bar. X * Configurable window borders. X XWWW: http://www.kde-look.org/content/show.php?content=5063 X Xbrian@quynh-and-brian.org END-of-aquaosk/pkg-descr echo x - aquaosk/pkg-plist sed 's/^X//' >aquaosk/pkg-plist << 'END-of-aquaosk/pkg-plist' Xlib/kde3/libkwinaqua_config.so Xlib/kde3/libkwinaqua_config.la Xlib/kde3/libkwinaqua.so Xlib/kde3/libkwinaqua.la Xshare/apps/kwin/aqua.desktop X@unexec rmdir %%PREFIX%%/share/apps/kwin 2>/dev/null || true X@unexec rmdir %%PREFIX%%/share/apps 2>/dev/null || true X@unexec rmdir %%PREFIX%%/lib/kde3 2>/dev/null || true END-of-aquaosk/pkg-plist echo x - aquaosk/distinfo sed 's/^X//' >aquaosk/distinfo << 'END-of-aquaosk/distinfo' XMD5 (aquaosk-2.0.tar.bz2) = d9c7e7b71d1fb62b24087385bd4ad2e1 END-of-aquaosk/distinfo exit --Boundary-00=_n+Eq+dssbZSGYfL--