From owner-freebsd-ports@FreeBSD.ORG  Wed Dec 24 18:02:16 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 845B7106564A;
	Wed, 24 Dec 2008 18:02:16 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 39DCA8FC12;
	Wed, 24 Dec 2008 18:02:16 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1LFXIu-0008Fs-K2; Wed, 24 Dec 2008 20:13:52 +0300
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 2B0366E2D;
	Wed, 24 Dec 2008 20:12:10 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 4A13717032; Wed, 24 Dec 2008 20:14:13 +0300 (MSK)
Date: Wed, 24 Dec 2008 20:14:13 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Eitan Adler <eitanadlerlist@gmail.com>
Message-ID: <20081224171413.GA57137@hades.panopticon>
References: <49504D4B.8040402@gmail.com> <49515A77.3050204@FreeBSD.org>
	<BBBD0841-1639-4D64-BAA2-0B8108226BFF@gmail.com>
	<49517DB4.1060704@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <49517DB4.1060704@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: "ports@freebsd.org" <ports@freebsd.org>,
	Garrett Cooper <yanefbsd@gmail.com>, Doug Barton <dougb@FreeBSD.org>
Subject: Re: proposal: add --disable-tests to www/firefox3 port
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Dec 2008 18:02:16 -0000

* Eitan Adler (eitanadlerlist@gmail.com) wrote:

I'd suggest
-+.if defined(WITHOUT_DEBUG)
++.if !defined(WITH_DEBUG)

DEBUG knob is assumed to defauly to false, this WITH_DEBUG is checked
everywhere. See `grep -R _DEBUG /usr/ports/Mk`

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru