Date: Tue, 5 May 2020 20:56:42 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r360674 - stable/11/sbin/pfctl Message-ID: <202005052056.045KugTv088734@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Tue May 5 20:56:41 2020 New Revision: 360674 URL: https://svnweb.freebsd.org/changeset/base/360674 Log: MFC r335608 (by sbruno): Assuming that the intent (from the white space) is that the fprintf() be executed in the if() conditional. If its not supposed to be printed inside the conditional, then the braces should be removed and the extra tabs on the fprintf() should be removed. Noted by cross compilation with gcc-mips. Modified: stable/11/sbin/pfctl/pfctl_altq.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sbin/pfctl/pfctl_altq.c ============================================================================== --- stable/11/sbin/pfctl/pfctl_altq.c Tue May 5 20:53:45 2020 (r360673) +++ stable/11/sbin/pfctl/pfctl_altq.c Tue May 5 20:56:41 2020 (r360674) @@ -497,12 +497,13 @@ cbq_compute_idletime(struct pfctl *pf, struct pf_altq * this causes integer overflow in kernel! * (bandwidth < 6Kbps when max_pkt_size=1500) */ - if (pa->bandwidth != 0 && (pf->opts & PF_OPT_QUIET) == 0) + if (pa->bandwidth != 0 && (pf->opts & PF_OPT_QUIET) == 0) { warnx("queue bandwidth must be larger than %s", rate2str(ifnsPerByte * (double)opts->maxpktsize / (double)INT_MAX * (double)pa->ifbandwidth)); fprintf(stderr, "cbq: queue %s is too slow!\n", pa->qname); + } nsPerByte = (double)(INT_MAX / opts->maxpktsize); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005052056.045KugTv088734>