From owner-cvs-all Fri May 3 1:21:26 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 8BD5937B43A; Fri, 3 May 2002 01:21:14 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id 4BB72AE163; Fri, 3 May 2002 01:21:14 -0700 (PDT) Date: Fri, 3 May 2002 01:21:14 -0700 From: Alfred Perlstein To: Seigo Tanimura Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c kern_exit.c kern_proc.c Message-ID: <20020503082114.GG36741@elvis.mu.org> References: <200205030532.g435WQn93543@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200205030532.g435WQn93543@freefall.freebsd.org> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Seigo Tanimura [020502 22:32] wrote: > tanimura 2002/05/02 22:32:26 PDT > > Modified files: > sys/kern kern_descrip.c kern_exit.c kern_proc.c > Log: > Fix the lock order reversal between the sigio lock and a process/pgrp lock in > funsetownlst() by locking the sigio lock across funsetownlst(). This seems wrong. It looks like, funsetownlst should not need the proc lock, funsetownlst should only be called by the last exiting thread of a process. Right now there is a bug in kern_exit.c that calls funsetownlst for each exiting proc, this needs to be fixed, then I think we can do away with holding the lock over the entire function call. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message