Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 May 2002 01:21:14 -0700
From:      Alfred Perlstein <bright@mu.org>
To:        Seigo Tanimura <tanimura@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_descrip.c kern_exit.c kern_proc.c
Message-ID:  <20020503082114.GG36741@elvis.mu.org>
In-Reply-To: <200205030532.g435WQn93543@freefall.freebsd.org>
References:  <200205030532.g435WQn93543@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Seigo Tanimura <tanimura@FreeBSD.org> [020502 22:32] wrote:
> tanimura    2002/05/02 22:32:26 PDT
> 
>   Modified files:
>     sys/kern             kern_descrip.c kern_exit.c kern_proc.c 
>   Log:
>   Fix the lock order reversal between the sigio lock and a process/pgrp lock in
>   funsetownlst() by locking the sigio lock across funsetownlst().

This seems wrong.

It looks like, funsetownlst should not need the proc lock, funsetownlst
should only be called by the last exiting thread of a process.
Right now there is a bug in kern_exit.c that calls funsetownlst for
each exiting proc, this needs to be fixed, then I think we can do
away with holding the lock over the entire function call.

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020503082114.GG36741>