From owner-dev-commits-src-main@freebsd.org Mon Jan 11 19:15:10 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E67194E32D7; Mon, 11 Jan 2021 19:15:10 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DF3Lk5KxVz4jYk; Mon, 11 Jan 2021 19:15:10 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id 05D04181ED9; Mon, 11 Jan 2021 22:15:03 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id r5vAY9xKA6HL; Mon, 11 Jan 2021 22:15:02 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id 3365F181ECC; Mon, 11 Jan 2021 22:15:02 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id 6459342211F; Mon, 11 Jan 2021 22:15:01 +0300 (MSK) Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id ATspCdyn2jei; Mon, 11 Jan 2021 22:14:54 +0300 (MSK) Received: from [192.168.0.30] (gateway [10.0.2.2]) by mail.cicgroup.ru (Postfix) with ESMTPA id 8C7BD42211C; Mon, 11 Jan 2021 22:14:54 +0300 (MSK) Subject: Re: git: 16079c7233be - main - hid: quiet -Wswitch To: John Baldwin , Ryan Libby , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202101110554.10B5sW2q070743@gitrepo.freebsd.org> <700dd42d-2d73-e54a-5fcc-b62ed31df80d@FreeBSD.org> From: Vladimir Kondratyev Message-ID: <915475fa-0072-2303-dfc9-dbeb42224434@kondratyev.su> Date: Mon, 11 Jan 2021 22:14:43 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <700dd42d-2d73-e54a-5fcc-b62ed31df80d@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DF3Lk5KxVz4jYk X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 19:15:11 -0000 On 11.01.2021 21:03, John Baldwin wrote: > On 1/10/21 9:54 PM, Ryan Libby wrote: >> The branch main has been updated by rlibby: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=16079c7233be8bd6c88e3421a70c7ca87cfea370 >> >> commit 16079c7233be8bd6c88e3421a70c7ca87cfea370 >> Author: Ryan Libby >> AuthorDate: 2021-01-11 05:53:15 +0000 >> Commit: Ryan Libby >> CommitDate: 2021-01-11 05:53:15 +0000 >> >> hid: quiet -Wswitch >> >> Gcc builds complained that not all switch cases are handled. Add >> default cases to appease gcc. >> >> Reviewed by: hselasky (previous version), wulf >> Sponsored by: Dell EMC Isilon >> Differential Revision: https://reviews.freebsd.org/D28082 > > If these cases are never reachable, then I think '__assert_unreachable()' > is preferred to a plain break. > These cases are reachable. They are NOP steps of state machine.