From owner-cvs-all  Sat May 26 21:51: 4 2001
Delivered-To: cvs-all@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3262737B42C; Sat, 26 May 2001 21:51:01 -0700 (PDT)
	(envelope-from dima@unixfreak.org)
Received: from spike.unixfreak.org (spike [63.198.170.139])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id A800E3E30; Sat, 26 May 2001 21:50:57 -0700 (PDT)
To: Warner Losh <imp@harmony.village.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/kbdcontrol kbdcontrol.c 
In-Reply-To: <200105270431.f4R4VkE51578@harmony.village.org>; from imp@harmony.village.org on "Sat, 26 May 2001 22:31:46 -0600"
Date: Sat, 26 May 2001 21:50:57 -0700
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010527045057.A800E3E30@bazooka.unixfreak.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Warner Losh <imp@harmony.village.org> writes:
> In message <200105270403.f4R43r843630@freefall.freebsd.org> Dima Dorfman writes:
> :   Modified files:
> :     usr.sbin/kbdcontrol  kbdcontrol.c 
> :   Log:
> :   A la rev. 1.36, define CONS_CLRHIST here if it isn't already since
> :   this is a build tool, so it has to build on 4.x with the old headers.
> 
> A better solution would be to have #ifdef CONS_CLRHIST around its
> use.  We couldn't do that with PASTE because keymaps would break and
> disentangling that was a mess.  CONS_CLRHIST isn't required to build a
> correct system, so it should be ifdef'd.

I agree that this is a better solution than what I committed, but I
still think `kbdcontrol -L` should be factored out into another
program.  It seems silly that kbdcontrol can't rely on up-to-date
headers like most other programs in the system.

> Consider the following untested patch:

If we can't/won't factor out `kbdcontrol -L`, I'll commit this.
Thanks!  I knew there had to be a better way than defining an ioctl in
the userland :-).

					Dima Dorfman
					dima@unixfreak.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message