From owner-svn-src-all@freebsd.org  Wed Aug 22 07:51:27 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8999E1080893;
 Wed, 22 Aug 2018 07:51:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 33BC988898;
 Wed, 22 Aug 2018 07:51:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro-2.local (unknown [51.52.172.98])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 6D96810A87D;
 Wed, 22 Aug 2018 03:51:25 -0400 (EDT)
Subject: Re: svn commit: r338172 - in head: . sys/amd64/conf sys/dev/drm
 sys/dev/drm2 sys/dev/drm2/i915 sys/dev/drm2/radeon
 sys/dev/drm2/radeon/reg_srcs sys/dev/drm2/ttm sys/i386/conf sys/modules
 sys/modules/dr...
To: Hans Petter Selasky <hps@selasky.org>, Matthew Macy <mmacy@freebsd.org>,
 Andriy Gapon <avg@freebsd.org>
References: <201808220150.w7M1oDeA012487@repo.freebsd.org>
 <bad9d7c2-2c69-4c1e-fb40-c5dee38d77a1@FreeBSD.org>
 <CAPrugNq889GHwQv7sXrzRYUZ=GKi8qa9_+Hky_TOerHz4LKYLA@mail.gmail.com>
 <13c977be-0ee7-688d-4f61-837ccb5d5273@selasky.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org, Johannes Lundberg <johalun0@gmail.com>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <860aa5fa-1004-c19e-b928-1cbcc2c90f6f@FreeBSD.org>
Date: Wed, 22 Aug 2018 08:51:24 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <13c977be-0ee7-688d-4f61-837ccb5d5273@selasky.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Wed, 22 Aug 2018 03:51:26 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Aug 2018 07:51:27 -0000

On 8/22/18 8:41 AM, Hans Petter Selasky wrote:
> On 8/22/18 9:35 AM, Matthew Macy wrote:
>> Johannes - do you know off hand?
>> -M
> 
> Hi,
> 
> This function is still not implemented. This is part of the LGPLv2 part.
> 
> Probably the function and the restore companion doesn't have to panic.
> 
> --HPS
> 
>> static inline void
>> linux_pci_save_state(struct pci_dev *pdev)
>> {
>>
>>         panic("implment me!!");
>>         UNIMPLEMENTED();
>> }

Can't this just use pci_save_state() of the FreeBSD device_t?  If there
are bits of PCI space that pci_save_state() isn't saving that we need to
save/restore, we should probably just add those to the FreeBSD one
(e.g. additional capability registers).

-- 
John Baldwin