From owner-p4-projects@FreeBSD.ORG Mon Jun 18 09:33:40 2012 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 60E9D1065675; Mon, 18 Jun 2012 09:33:40 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D0CF106566C for ; Mon, 18 Jun 2012 09:33:40 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:4f8:fff6::2d]) by mx1.freebsd.org (Postfix) with ESMTP id 051428FC08 for ; Mon, 18 Jun 2012 09:33:40 +0000 (UTC) Received: from skunkworks.freebsd.org (localhost [127.0.0.1]) by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id q5I9Xdl3059251 for ; Mon, 18 Jun 2012 09:33:39 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id q5I9XdOk059248 for perforce@freebsd.org; Mon, 18 Jun 2012 09:33:39 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Mon, 18 Jun 2012 09:33:39 GMT Message-Id: <201206180933.q5I9XdOk059248@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 213057 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 09:33:40 -0000 http://p4web.freebsd.org/@@213057?ac=10 Change 213057 by rwatson@rwatson_svr_ctsrd_mipsbuild on 2012/06/18 09:32:59 Remove XXX comments about pipeline issues with CP2 forwarding; we believe these to be fixed in hardware, so nops were removed. Let the comments catch up. Affected files ... .. //depot/projects/ctsrd/cheribsd/src/sys/mips/cheri/cp2.h#7 edit Differences ... ==== //depot/projects/ctsrd/cheribsd/src/sys/mips/cheri/cp2.h#7 (text+ko) ==== @@ -178,15 +178,6 @@ * * XXXRW: C macros are named after capability field names -- hence OTYPE * rather than TYPE. Possibly this is a bug. - * - * XXXRW: There is currently no forwarding of general-purpose register - * operands into capability manipulation instructions. We therefore have to - * take care to nop several times after possible loads of values that will be - * immediately passed into them. - * - * XXXRW: We also space all capability instructions with several nops on - * either side in order to ensure they don't follow through the pipeline too - * closely. */ #define CP2_CR_MOVE(crn_to, crn_from) do { \ if ((crn_to) == 0) \