From nobody Sun Feb 12 22:18:44 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFMM45twjz3pFyT for ; Sun, 12 Feb 2023 22:18:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFMM45SH0z4WXM for ; Sun, 12 Feb 2023 22:18:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id d40so9376728eda.8 for ; Sun, 12 Feb 2023 14:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=diR/hkwJG8qvHeiDy+9OLWvdzbOr7gj4G/Nv7DY84gI=; b=Sn6SDOc5PKR6/xsCpis4EiAFIH8Kgx74PvruxNhB5RsbXFVWGsw75hY83brrCcAn38 w1brQRPxyb6eQFIeXofhqFku59lJmNZ82R1JTtMONKeZtH/r/+m5S4ybM6wDIZC9eAvh w8FO3hkVsgUoxGt0m0+ZEwXdtt6JKDdKtM1h0HjroNWAkh43YqhktEwLpOJhxXRQeFZ1 VAYrxZ2voVGiG8YTvktuzRs8XpfW4Fw4a3J4LL7t3WrAIB0tlMM863qlQVOuyeDwWSwm fnt5ujANbBjC+h59BuZwLnQtUMEjv8E2w/4dBETg55ewN1r/GBnVQm/rBeO1ZabByX9c iYiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=diR/hkwJG8qvHeiDy+9OLWvdzbOr7gj4G/Nv7DY84gI=; b=dVhB3y87tD6dvO0nnICNqFo0doF57YFSQSoIJGptBPyFkKl2mMTuNz5ic4EJmJ9wud ZFoffU46RBQKXFXb3wPypEvp/+yrIRNEfvSp3qutYawZrAvpq0I6XgUe2aOZV1zIuODJ /eF9IL0h6COCDQ9sd/XJBjrWDdyXEe7ox7nPQoT4vlLZqNR71BwbpoNvic3d+/KXjpKr PbA+NN9WZNXKwwnVnApz6XI7ZyfZ86oLWmGO2HjdEk5ZMgefxCSKBdM6s/Vy/QqInV1s OmXzqQrZhtWSGmhzHENJ26ChCVo27WcFmnSkU3+9B/Y5qdc37y2LdXnvs4NV6DEBQewT vqPA== X-Gm-Message-State: AO0yUKXqssjSPvieGdrppbPxih2/bpakHRM6t9O4z1vWAqKTN6YXcEE5 QZ8Vqhy4jSukmfuUl24XUvgyEYWxLz96N1O9PD7PFpDMbJroFxpC X-Google-Smtp-Source: AK7set/c2xVFvOz/uZVwah3EONC6wNbj/PYFi/xmiQAsNFm9srzQVwPdJfAPLX/ETAM1LERC+JzI5Qbhi61t4eXZ+JE= X-Received: by 2002:a50:9e4b:0:b0:4a8:2436:4ed2 with SMTP id z69-20020a509e4b000000b004a824364ed2mr5915797ede.0.1676240335574; Sun, 12 Feb 2023 14:18:55 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sun, 12 Feb 2023 15:18:44 -0700 Message-ID: Subject: Re: Build breakage with WITH_BEARSSL=1 To: Gordon Bergling Cc: freebsd-current@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c2a6c005f4881dd2" X-Rspamd-Queue-Id: 4PFMM45SH0z4WXM X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000c2a6c005f4881dd2 Content-Type: text/plain; charset="UTF-8" On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: > Hi, > > I am currently seeing a build breakage when building -CURRENT with > WITH_BEARSSL=1. > > The error is the following > > make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: > warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.asc 2> > /dev/null" returned non-zero status > /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a > function declaration without a prototype is deprecat ed in all versions of > C [-Werror,-Wstrict-prototypes] > br_rsa_i62_keygen_get() > ^ > void > 1 error generated. > --- rsa_i62_keygen.pico --- > > > When disabling BEARSSL in the src.conf the build succeeds as usual. > > Has anyone also seen this build error. Sources are very recent and the > src.conf is the following: > > WITH_EXTRA_TCP_STACKS=1 > #WITH_BEARSSL=1 > WITH_PIE=1 > WITH_RETPOLINE=1 > WITH_INIT_ALL_ZERO=1 > WITH_OPENSSL_KTLS=1 > WITHOUT_CLEAN=1 > > Any help is very appreciated. > > What does the following do for you? It's a cut and pasted patch, but it should be clear enough what to do if the mailer mangles it. diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc index dd0e242c8ef0..2af4864d8441 100644 --- a/lib/libbearssl/Makefile.inc +++ b/lib/libbearssl/Makefile.inc @@ -4,4 +4,4 @@ BEARSSL?= ${SRCTOP}/contrib/bearssl BEARSSL_SRC= ${BEARSSL}/src CFLAGS+= -I${BEARSSL}/inc - +CFLAGS+= ${NO_WDEPRECATED_NON_PROTOTYPE} Warner --000000000000c2a6c005f4881dd2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Feb 12, 2023 at 3:54 AM Gordo= n Bergling <gbe@freebsd.org> w= rote:
Hi,

I am currently seeing a build breakage when building -CURRENT with WITH_BEA= RSSL=3D1.

The error is the following

=C2=A0 make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk"= ; line 109: warning: "cd /boiler/nfs/src/lib/libsecureboot && = 'ls'=C2=A0 =C2=A0-1 *.pem t*.asc 2> /dev/null" returned non= -zero status
=C2=A0 /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: a function declaration without a prototype is deprecat=C2=A0 ed in all v= ersions of C [-Werror,-Wstrict-prototypes]
=C2=A0 br_rsa_i62_keygen_get()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 void
=C2=A0 1 error generated.
=C2=A0 --- rsa_i62_keygen.pico ---


When disabling BEARSSL in the src.conf the build succeeds as usual.

Has anyone also seen this build error. Sources are very recent and the
src.conf is the following:

WITH_EXTRA_TCP_STACKS=3D1
#WITH_BEARSSL=3D1
WITH_PIE=3D1
WITH_RETPOLINE=3D1
WITH_INIT_ALL_ZERO=3D1
WITH_OPENSSL_KTLS=3D1
WITHOUT_CLEAN=3D1

Any help is very appreciated.


What does the following do for you? It= 's a cut and pasted patch, but it should be clear enough what to do if = the mailer mangles it.

diff --git a/lib/libbearssl= /Makefile.inc b/lib/libbearssl/Makefile.inc
index dd0e242c8ef0..2af4864d= 8441 100644
--- a/lib/libbearssl/Makefile.inc
+++ b/lib/libbearssl/Ma= kefile.inc
@@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
=C2= =A0BEARSSL_SRC=3D ${BEARSSL}/src

=C2=A0CFLAGS+=3D -I${BEARSSL}/inc-
+CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}

=
Warner

--000000000000c2a6c005f4881dd2--