From nobody Fri May 29 16:01:54 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gRp5G626gz6flWB for ; Fri, 29 May 2026 16:01:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gRp5G3CmXz3J08 for ; Fri, 29 May 2026 16:01:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780070514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ys50pLuQT+xKGkoHlKEr/0djjte9GEuo7DORh7nCsc4=; b=Vve/7JGkduvqy+zNeSEFPjJ3ogi2ECnAVz/DnsJxO+eFOp/iq5nN9x/Hg+aDVAnpUyBmez z3Xi1xNELWIYqqt5Q0BaG2Y1UUw8k94/9BwEjBsISQHzj1GNw+tZOF6YHYo4XS8uIPxBX6 4N7s5n4oIm2PLyOQaVO3+Et0y+QTp1d7E3WI9oobReJuBxgfJEhWq88/XdXsWStZQvKx04 3xanDqlbCYqpqIgxGQsO1hcsW5oKmDv9PDLtNfrkQs1bN3MQ1T8unjM9+6x4Z+UkjW80wi oF+gD4OjrRwffBkWdzvcszmpIzAaoNPmHiM8gPfsMSFWXpcw/ZmYjLuVDvo5ZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780070514; a=rsa-sha256; cv=none; b=T7bW2F06Mc/NMv8AIakaMcoUcgb527yZ/FOXWYg1Gr7bJdEhbWEWv+ptRmUtWIufe49DZ7 rWiYACipUQnbwFY0+ZY7N/t0DdsTyRytjywCQuiUl8VfTCQIHD830AERrzt7UEE7FTsMVz 3zZXz+C5DoOftg5FwcT9yl82rwlSFuP59rRIjZ6WkdVDuh25F1o3/aCixvQJ8jb/eAuL8w rM95BsqipZnn8wwC+tbXHV5AZLYL7MAi9DVxEIBdMK7M06cd8hHETh5aCHkTJDKB9tCPwq 2f04rYX3ifMUFgzTXfqpwOKPnV53UJDer5VEcrnxB256bOd8nlL3B6Y1GH2JLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780070514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ys50pLuQT+xKGkoHlKEr/0djjte9GEuo7DORh7nCsc4=; b=L0lPZTvBwd8mDDrMmjphqPCHLRfFp7wQnDgo3HQgXX3dVL5ovOkDwbf+tEa+aSYVG5O3WO 8JyzAY/tQdQf9gdlv1SohYMewCI3IaZXkJF858d7mDhfoyb67wXgiV8h7MGv+TgV50FJKf nuVzCTwzqVCKS+5Q6o0itcXsFB3/Cw0+jQWRuQLcC2J+zY2JquyvZL216ySUNeQftfqeYq HXRT3QH6Jum8ofhH/a0ukgagFc7jWVwOx2NajsGrTGjUHa+7y4xB42M4p9iwo30NKZYwJq 1IQbSYufpnJ5VqbDOtquZkJKQ+VK9CP7HUzjkvKo7XZJrsLgFmmm8IiQixOKug== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gRp5G2fFkzgrp for ; Fri, 29 May 2026 16:01:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36802 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 29 May 2026 16:01:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 5bedb5e44757 - main - MAC/do: Comment to explain the main invariant for configurations List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5bedb5e44757ba83dba9d618f5b951416cf44345 Auto-Submitted: auto-generated Date: Fri, 29 May 2026 16:01:54 +0000 Message-Id: <6a19b872.36802.4ec96f57@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=5bedb5e44757ba83dba9d618f5b951416cf44345 commit 5bedb5e44757ba83dba9d618f5b951416cf44345 Author: Olivier Certner AuthorDate: 2026-04-29 17:11:34 +0000 Commit: Olivier Certner CommitDate: 2026-05-29 15:33:24 +0000 MAC/do: Comment to explain the main invariant for configurations Once visible, configuration structures must *never* change. Spell that out in a comment to help future readers/contributors understand the design. Reviewed by: bapt MFC after: 1 month Sponsored by: The FreeBSD Foundation Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/38 --- sys/security/mac_do/mac_do.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/security/mac_do/mac_do.c b/sys/security/mac_do/mac_do.c index 125054d15423..4e7a65ae2cae 100644 --- a/sys/security/mac_do/mac_do.c +++ b/sys/security/mac_do/mac_do.c @@ -210,6 +210,11 @@ struct exec_paths { int exec_path_count; }; +/* + * Once in use, i.e., being pointed to by a jail, a configuration structure MUST + * NEVER CHANGE (except for the 'use_count' field). This invariant is + * fundamental to correctness! + */ struct conf { struct rules rules; struct exec_paths exec_paths;