From owner-svn-src-all@freebsd.org Fri Jan 24 01:18:05 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 27D2722A5C3; Fri, 24 Jan 2020 01:18:05 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 483h8s0K8kz4KCq; Fri, 24 Jan 2020 01:18:04 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-qv1-xf2f.google.com with SMTP id dp13so167506qvb.7; Thu, 23 Jan 2020 17:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+1uRfPs4ilJ5APFT2mvDNDiDack8WzbJErFGzoxElFM=; b=CD8at/zQY2ouCTg5VEI4qscKlb9MUzA/fH6RSlikmpbq++14jSt8ZAQ97QCC4kH1A+ rQb84iZAJt+nKfwXJephNv/xPR6t1mmHLxlGzZzDERqi+Ufd2mqeZcUtwgoxreMwQcJn X57PMHKnyUCo1SYHJArOt0RELbbmq9sfjGduF+rKAP8LNQLHnlayDPGyENEdeM9DOrk1 DQusHB9omXIjEI2/71Z3S4/nlnoWdoHvCLAu/hZMV6HELp95caNHy9ewwsHlSSnstq2l d7sS5AfRyBXRzB/b/5+baHr2aQZze3QxUMsLyuoLOmHo64PHJFxw6YfAHV+wlZZVisUg bbeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+1uRfPs4ilJ5APFT2mvDNDiDack8WzbJErFGzoxElFM=; b=nrl4wNzngRN4JPFjG1gkGLxaeeVp7OXlmUVDeZ8W7BBqX5Z1ocK/SVaNFMMnOX6Y3I +z2n+EzMrBAl78gk/ckP6vj7j3oYbGxDzrL6Oz1BRvMl7OkBCX97+OSaOBcwUoSamG7H dyu3mkenix059ORY18jjF5di1aP5AmPnh+rUQ11T5ICkK/5Mgg3PmffLdbqCIxt+ajKD RHAoxbFKatEKQlQ4hOWzAJI6dDkHTMHjMlrjaBu6Ox4QXikXpssThK9btiLup+ie/FTA bLxGsszLiqyZ12/W/4gDKmRU/fTggFyagsgYD8W2uM/Y9uNqokAn8/Qb+abkYKYcBX9g LaJA== X-Gm-Message-State: APjAAAVFoHP05Rnv4NQkkiQ3kbiYLXH3osWR+qItJ2a56KrXR7XBIA7W PorBtw1s9fzcCP4V21/mGvIo88BU+ysltp06wMKzeCeK X-Google-Smtp-Source: APXvYqx2t98CCUEa9x98k/I5y5ycHywV6mfGptxCda57BZ5pNBc2u45zdJlaAnZV9AeQwVgRJmzWDjWQSNKB8khA8Vg= X-Received: by 2002:ad4:4434:: with SMTP id e20mr522354qvt.157.1579828677699; Thu, 23 Jan 2020 17:17:57 -0800 (PST) MIME-Version: 1.0 References: <202001231636.00NGawrr080128@repo.freebsd.org> <20200123230546.GG1268@FreeBSD.org> In-Reply-To: <20200123230546.GG1268@FreeBSD.org> From: Ryan Stone Date: Thu, 23 Jan 2020 20:17:46 -0500 Message-ID: Subject: Re: svn commit: r357051 - head/sys/dev/bge To: Gleb Smirnoff Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 483h8s0K8kz4KCq X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2020 01:18:05 -0000 On Thu, Jan 23, 2020 at 6:05 PM Gleb Smirnoff wrote: > > On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: > R> What is a driver's responsibility now for entering/leaving the net epoch now? > > For drivers that are 'special', entering the net epoch is necessary. Special > usually means running if_input outside network interrupt context. > > However, there is plan to generalize entering/exiting epoch for taskqueues > and callouts. Why on earth is it done that way rather than putting the network epoch enter/exit in ether_input? I'm with Ian; this sounds like a huge layering violation.