Date: Wed, 29 Jul 2020 00:39:49 -0600 From: Adam Weinberger <adamw@adamw.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Adam Weinberger <adamw@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r543637 - head/net/rsync Message-ID: <E05DF43F-CD66-4FF3-9B48-D0520D0A3498@adamw.org> In-Reply-To: <20200729050719.GA2915@FreeBSD.org> References: <20200729050719.GA2915@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>> On Jul 28, 2020, at 23:07, Alexey Dokuchaev <danfe@freebsd.org> wrote: >>=20 >> =EF=BB=BFOn Tue, Jul 28, 2020 at 11:51:00PM +0000, Adam Weinberger wrote:= >> New Revision: 543637 >> URL: https://svnweb.freebsd.org/changeset/ports/543637 >> Log: >> rsync: Unbreak and fix depends >> @@ -19,7 +19,7 @@ LICENSE=3D GPLv3 >> LIB_DEPENDS=3D libxxhash.so:devel/xxhash \ >> libzstd.so:archivers/zstd >> -USES=3D cpe shebangfix >> +USES=3D cpe shebangfix ssl >=20 > Is there reason why also adding `localbase' or `localbase:ldflags` here > on the USES list... >=20 >> +CPPFLAGS+=3D -I${LOCALBASE}/include >> +LDFLAGS+=3D -L${LOCALBASE}/lib >=20 > ... rather then explictitly amending these variables was not preferred? My objective at the time was fixing some build failures. The blanket covers s= witching to USES, and I definitely encourage you to do so here. Idioms like l= ocalbase matter; the more we use them, the more the ports metalanguage evolv= es. For the record: The initial intent of USES=3Dlocalbase wasn=E2=80=99t a simp= le way for ports to say =E2=80=9C-I$LB/include -L$LB/lib=E2=80=9D. A long ti= me ago, I recall Baptiste telling people (myself included) to knock it off. I= =E2=80=99m sure it=E2=80=99s evolved since then, but I=E2=80=99ve almost nev= er used it since! # Adam =E2=80=94 Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E05DF43F-CD66-4FF3-9B48-D0520D0A3498>