From owner-svn-src-head@FreeBSD.ORG Sat May 17 04:12:38 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BC48AD00 for ; Sat, 17 May 2014 04:12:38 +0000 (UTC) Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8DA692A62 for ; Sat, 17 May 2014 04:12:38 +0000 (UTC) Received: by mail-pa0-f43.google.com with SMTP id hz1so3363633pad.30 for ; Fri, 16 May 2014 21:12:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=TJLDxsjiT0H1QK5FW9Qu21X02q5cW/wq9eJYM41+FVA=; b=YVy5X96H7JO/eWdUqhlD5HXhGwLUnteB40mSTwosyUjf7nyLne725ncFm+IV4QSkhG L8USgkqQ6fXYYKCfQ5oDhVxBpgkTjZQE0EQE2RdpvpS8HsXfrbV3wVvWkGKY1Oqq2aHF upgtC5a927x+MUBeC5IuiUwveWatQAhR0tMjULC7a6UBP9NbIcJRmyN+qwR0AT7Rs3k2 UVxOXaIq8T4LHCFkcSf8kJS6AYrzIPTJwgvjKTuHZvtOKdlm4vA6ubgHp32N0pJ26hoy DYvTcM59pVhPc9nySnawNoa9jNLUfkACSKxokmEMETjSzYiA/S/fVnezHFmm8XkfcDSZ l9Ow== X-Gm-Message-State: ALoCoQnPrU/hI3979xEH21kgI7kxtowGo+/62aI43DHZVla4zc/p4jsfUq84ZqXqQOaX3RWlmZza X-Received: by 10.68.193.100 with SMTP id hn4mr26024747pbc.50.1400299497836; Fri, 16 May 2014 21:04:57 -0700 (PDT) Received: from [10.64.24.248] (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id qv3sm17317048pbb.87.2014.05.16.21.04.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 May 2014 21:04:57 -0700 (PDT) Sender: Warner Losh X-Google-Original-From: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: svn commit: r266238 - head/contrib/ldns/ldns From: Warner Losh In-Reply-To: <86ppjdjg2c.fsf@nine.des.no> Date: Sat, 17 May 2014 00:04:43 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <4A83A11B-EFDD-46C5-B9D4-D81EBD4FAAAE@gmail.com> References: <201405161532.s4GFWGvh006504@svn.freebsd.org> <20140517112645.N925@besplex.bde.org> <86ppjdjg2c.fsf@nine.des.no> To: =?windows-1252?Q?Dag-Erling_Sm=F8rgrav?= X-Mailer: Apple Mail (2.1874) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Bruce Evans X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 May 2014 04:12:38 -0000 On May 16, 2014, at 10:26 PM, Dag-Erling Sm=F8rgrav wrote: > Bruce Evans writes: >> -Wcast-qual is especially onerous in contrib'ed code written to a = lower >> standard. >=20 > Well, I could have just lowered WARNS... LDNS actually isn't that = bad. > Unbound is much worse. >=20 >> Converting this to use system endianness conversion functions = wouldn't >> take much more churn. >=20 > Do our standard endianness conversion functions handle unaligned > accesses? No. The warning appears to be telling us something that=92s being = papered over. Warner