From owner-cvs-all@FreeBSD.ORG  Sun Apr  9 16:35:15 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 29BE816A401;
	Sun,  9 Apr 2006 16:35:15 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C9A6A43D45;
	Sun,  9 Apr 2006 16:35:14 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 3955746C10;
	Sun,  9 Apr 2006 12:35:14 -0400 (EDT)
Date: Sun, 9 Apr 2006 17:35:14 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
In-Reply-To: <20060409090541.GG2135@garage.freebsd.pl>
Message-ID: <20060409173429.T55490@fledge.watson.org>
References: <200604011542.k31Fg2B3020856@repoman.freebsd.org>
	<20060409090541.GG2135@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c
 uipc_usrreq.c
 src/sys/net raw_cb.c raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c
 src/sys/netatm atm_aal5.c atm_socket.c atm_usrreq.c atm_var.h
 src/sys/netgraph ng_socket.c ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Apr 2006 16:35:15 -0000


On Sun, 9 Apr 2006, Pawel Jakub Dawidek wrote:

> +> -static int
> +> +static void
> +>  ngd_detach(struct socket *so)
> +>  {
> +>  	struct ngpcb *const pcbp = sotongpcb(so);
> +>
> +> -	if (pcbp == NULL)
> +> -		return (EINVAL);
> +> +	KASSERT(pcbp == NULL, ("ngd_detach: pcbp == NULL"));
>
> From what I see, it should be:
>
> 	KASSERT(pcbp != NULL, ("ngd_detach: pcbp == NULL"));

This has already been fixed in ng_socket.c:1.73.

Thanks,

Robert N M Watson