From owner-freebsd-current  Fri Oct  4 19:10:24 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 97C9537B401; Fri,  4 Oct 2002 19:10:23 -0700 (PDT)
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by mx1.FreeBSD.org (Postfix) with SMTP
	id E458943E42; Fri,  4 Oct 2002 19:10:19 -0700 (PDT)
	(envelope-from iedowse@maths.tcd.ie)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <ab54012@salmon>; 5 Oct 2002 03:10:18 +0100 (BST)
To: Robert Watson <rwatson@FreeBSD.ORG>
Cc: Terry Lambert <tlambert2@mindspring.com>,
	Emiel Kollof <coolvibe@hackerheaven.org>,
	Peter Wemm <peter@wemm.org>,
	Poul-Henning Kamp <phk@critter.freebsd.dk>,
	n0go013 <ttz@blahdeblah.demon.co.uk>,
	current <freebsd-current@FreeBSD.ORG>
Subject: Re: [ GEOM tests ] disklabel warnings and vinum drives lost 
In-Reply-To: Your message of "Fri, 04 Oct 2002 20:07:11 EDT."
             <Pine.NEB.3.96L.1021004200338.70577U-100000@fledge.watson.org> 
Date: Sat, 05 Oct 2002 03:10:12 +0100
From: Ian Dowse <iedowse@maths.tcd.ie>
Message-ID:  <200210050310.ab54012@salmon.maths.tcd.ie>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In message <Pine.NEB.3.96L.1021004200338.70577U-100000@fledge.watson.org>, Robe
rt Watson writes:
>However, here's a patch that makes Vinum use namei() to rely on devfs to
>locate requested devices instead of parsing the device name and guessing
>the device number (incorrectly with GEOM).  Unfortunately, I almost
>immediately run into a divide by zero due to a zero sector size.  Jeff
>Roberson mentioned to me he had a fix for this bug that he sent to Greg,
>but that was never committed.

The divide by zero problem seems to be caused by an interaction
between two bugs: GEOM refuses to return the sector size because
the flags passed to d_open in vinum's open_drive() do not include
FREAD. Then vinum clobbers the ioctl's non-zero error code by calling
close_drive() from init_drive(), so the latter ends up returning
zero even though it failed.

The next failure I get is:

	Can't write config to /dev/da1s1d, error 45 (EOPNOTSUPP)

Ian

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message