From owner-svn-src-head@freebsd.org Sat Sep 10 07:12:29 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B696CBD49B1; Sat, 10 Sep 2016 07:12:29 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0103.outbound.protection.outlook.com [104.47.36.103]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3061C998; Sat, 10 Sep 2016 07:12:28 +0000 (UTC) (envelope-from sjg@juniper.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5y3EUQErqJrDHL3xt9C32LFqayevorTx9OwjJ581R/c=; b=bF3H/I55LcA2NpkPevCqnyPQxvso/PH0/GqGFglLMTvGoIC6baGqaj9jh07oxent9D/Sqv34u6cHDASGOvb4x1mOCxM/Q4+StuC3gaOa/smMnSQlRv7o2KoUYGnCNdDEHvjLPU08WVoMSg6eV5edWLO9e7vFxTvKTFXZ/0+Twwg= Received: from MWHPR05CA0023.namprd05.prod.outlook.com (10.168.242.161) by DM2PR0501MB986.namprd05.prod.outlook.com (10.242.174.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.619.3; Sat, 10 Sep 2016 00:37:48 +0000 Received: from BN1BFFO11FD028.protection.gbl (2a01:111:f400:7c10::1:142) by MWHPR05CA0023.outlook.office365.com (2603:10b6:300:59::33) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.544.10 via Frontend Transport; Sat, 10 Sep 2016 00:37:48 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.18) smtp.mailfrom=juniper.net; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.18 as permitted sender) Received: from p-emfe01a-sac.jnpr.net (66.129.239.18) by BN1BFFO11FD028.mail.protection.outlook.com (10.58.144.91) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.6 via Frontend Transport; Sat, 10 Sep 2016 00:37:48 +0000 Received: from p-mailhub01.juniper.net (10.160.2.17) by p-emfe01a-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 9 Sep 2016 17:37:28 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.30.60]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id u8A0bRuD013622; Fri, 9 Sep 2016 17:37:27 -0700 (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 5B1BD38551E; Fri, 9 Sep 2016 17:37:27 -0700 (PDT) To: Bryan Drewery CC: , , , Subject: Re: svn commit: r305634 - head/share/mk In-Reply-To: References: <201609090121.u891LZOO023156@repo.freebsd.org> Comments: In-reply-to: Bryan Drewery message dated "Fri, 09 Sep 2016 11:29:16 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <76523.1473467847.1@kaos.jnpr.net> Date: Fri, 9 Sep 2016 17:37:27 -0700 Message-ID: <76524.1473467847@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.18; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(7916002)(2980300002)(189002)(24454002)(199003)(2810700001)(23726003)(47776003)(4001430100002)(8676002)(92566002)(8936002)(97756001)(19580395003)(81156014)(2906002)(117636001)(9686002)(86362001)(50226002)(81166006)(586003)(19580405001)(68736007)(7126002)(77096005)(189998001)(110136002)(87936001)(97736004)(107886002)(50986999)(69596002)(2950100001)(356003)(5660300001)(76176999)(50466002)(7846002)(106466001)(105596002)(305945005)(46406003)(76506005)(53416004)(11100500001)(626004)(4326007)(450100001)(7696004)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR0501MB986; H:p-emfe01a-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD028; 1:BVBd+I88dNyBUWmsC2LxWZQf0Nbns2DglNtcpiin1/BYxtMmCKLGw0NIFV1/JJ5OInHOXvLEey7RnEY+9jgl3GkHJcN6e4E24MAaxP3MElFFiTsBtMPixzMaaQJczzSLp4KyfJ8VLkGJJXaqjalkxG9nQhHqeNW7U+575UdZ19IQmfe3vzajeofGZDXN43UWkgjM0280Mm7R9lY8Ucxw4iV1+CCYeFS8YiJWu9AS9xtiNiqch7g7CiNJ1MNUm5FFVt7J6HrhlymOMXYwsl/vH4SwoXoYU8NNseaaGgPtuudeNVpXCk0E5adN+y9l2GV9TOK2whvUmGJkRVaLvqLty/jPYrCw1BIrLCQc4cDnT08vJMUuK/bvm55bVqjJxDhrXcmr7UNXjg8oMczhN4Z5hcMS9ZjnUyr3ut448EbZWb2VUKI7FG+eNZY/u+QXNcADRY/tuqYc2s4XFSVs8w4scHQ8CiI7DSJogvkdbeyGONGsRNpg1nVZtRf87VAqt8gAOyGaVHihAStMEV1DpKHV/JBE4tG4aKGZh5VoVIWJMHg= X-MS-Office365-Filtering-Correlation-Id: 7bdc4754-7cf3-4eea-bfa6-08d3d912b090 X-Microsoft-Exchange-Diagnostics: 1; DM2PR0501MB986; 2:+xD0v9OphE7fk9sO3FGX3G/xe36uTtDYtv5oyKG2rCYF+KPQVAKNfTvwuTTjibfXrsq8QcF/PbdnZKtCN7zFhuZlfp0H/EHo1el0qLC2ATNwqGa6rsg1Gf9+ZnIlTkjq6a4VzVW/ueOOEUA64RW85BtC8ahdzkCwOtiUIDFBhm8uAWad081hZINSF0WWSC5Z; 3:pLABGRGA4dmXwFFPny01XhxxODqfQcouIh0AM8DesB8n0kmivzCifjuUiMR3SrGsFceYUWhsjnhOhMSXTdx+PEpWLy+afcVQTclsEMTrJJXJbJAqPi16+lGx7BuhiUPcMsRHgB+/FDKNpA/HuhJMYYrLxOxlx4M9cFD7StbxllNR06E9HKEmJMTvOSqpf1p5QeQw8xp+hglBjl/s0pHlS+rtNcYTM86wh/+XJOftXf8=; 25:jzIOA64bvXlcT+kXHwwukMl0INTVzU7lf9xYVdMT4HfTGhDKhYBY/yU2TwJrfzki3o06qwnHdUIC4ayKmzCZ1RrBgShnHmMKSiosi9yLLmBWxS+vqDJp5Xq20BexaqKhklUHgBhFAyvQBBEEamr2d5+p0gw74Q2c5l0qcfTxx4G6p3cqnQ1EQOM/e0ydg261u2WBW+emI+8dqbd+Mr7bn0bd/PpxHYdEb9UAuQXFBelGY1yrGelZjaNPlfJGJ4/xQ40j/unQ2qRIQFWP770WZROm2z6g4w3E+K0UQEMI4CfGwNNWKu1xBNxvC8dchv0E9aXhzjYmGDesnw8l/9BWA/qSRtjhC5y/bTThYdqj60/ow7Z/SXIp2ehNLDEoJz2B1CWLO9gt01z0g+zpekzLN+Y7sy/NPI2PP92w1j89nFo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0501MB986; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0501MB986; 31:O0t8UrHbqaxqZCskoor7mV1D/L71nns2xFDdzin3dlYP6jWrRHx/XionYHS9aFD2z/TbaRf0/5Pp1Q5PPCCRAtMN9Lt0QYubkoUCMiBl7oPvenXP415zzeztxMnN1fXEGK1zQpE6XWU03HPdiTkoF0ld4sXbHyTy7PnD8IU5/PIXXoL3Eon3m3NWUYuS5jLGrWlN3Lz+kF0KiZGr0R6lvDh+V8BWdICIo5Qsi7IKhH4=; 20:bapJ9Tcvrq15mN9/8GC+3bGv9zSSp4zfOXyQt4QZ9ey/6Jou3h8MQkE4DL6X1lenpzKv7zcRzdlwl3u5fdbIGONLTfXe4AEUJcvv9AROYEZuX5LVT4pxHE/2CsgzL45acQ5tQRm/VD+E8G4SWPyWswtmUiy2OAkmUMuw1tdqvTHXSF3R5m2T13Djaim9xOiiJhq7Try20zJ89o35hjFCnRpEonWN6DwjMisVBTqEI/o/EWTjQZJ38gJKIsdfe/bf2+8wqLUDkQLMdCGD8tiOSiyDF7UXXpeR5A5b43TZ56afoxLDIFscYD7ND2z1LGk4RZfPhloZJ5ZEtMeNp9vIP3WH245+mNsmrXyr3T0rTElwr0Ij4ml3lljIYSpBsiYTgbgYcUgZ4sSgeX8UrgNOe7rPAyZY35DwjGvFy4iXGwOUwvmG2zKKAL5qzOGdPyj9bp44KgPR34RPL/xrGY7sZg++oyqZEYRwGR7J+RWUZwpImlb5tt2qKLI/QU+LBKdt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13017025)(13015025)(13024025)(13023025)(13018025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:DM2PR0501MB986; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0501MB986; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0501MB986; 4:lzgFE5sjpqbCS1fWmrMDdJCv0RDnc2ABoEgsA1G4NkZ8LYsz9yVk5/QxpuLShSVqz3tlJQhKi0S+PMMb/NM6a9roLorAegUq0hv7XGQibzjri9BNhBF+M7li1ohqEEW6VoZBSb2rMVG888kqte5Z9vUnBAlyqXxjw4xS6e2o6e8YXwRuGqTTn1Nv4PcDLcQti66ycV9CMUK2H/C2Yfvn4GP9FUfeXlkUxB9YhvEPjqn+btYxZEvfZRhqN0heCDN61KGw3LeIbe9W8UtBRjC3aEbGS7WBgjqS1aCUhh+sBCkeU9QhXc9UcIjguDv2ir7RJmgz+ZjvEWJYFlh2Rm+Jyq/kUjiUV4XyMLNlgKxOeSHIu24XZ4ACs4Chscb1s+vzeEQdBIaohbqaPwZn6vGbPTrs8gkNo0dJN4HWbY0TJft/l7v7RjYnISLWsdpPNNmRJX5rDvWDGJzWoG3YMWLJDQOwImH0xSp0CMbvoayyNEGjVaYFkNcPxDGxG6VPPLAU X-Forefront-PRVS: 0061C35778 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR0501MB986; 23:tfyza0vACZH6Ihrh/Kw9qJhTJFv0ZIFMQ1vukaG6?= =?us-ascii?Q?zYcZ4qReICMNRPJJUy0tcrm9uF5sgrg+nVJLoleQIjjS6JzUvy30/09gplFO?= =?us-ascii?Q?ZR96NwgwBxhjljU9m1bx915m5tt1uFFCMkuiJwzIZlHRRZttWVM/vDrvnQg7?= =?us-ascii?Q?WAsKZL38+HUxkS6LuWXRgqbWxTltPQR/juMXQdWJqJSR4bYIopvV5+5b4A/N?= =?us-ascii?Q?H8DtCrz6twEjUKgoKPpumFbr/spUjg68l7xKiFebeBva2SiUEtvJ978Fx4GF?= =?us-ascii?Q?Wb5GmZoPk+b73ecFfqaBYGqfiVNo5JuO9KLHAc5fPjFCVIsnc2vF2VD5Z20n?= =?us-ascii?Q?rpZ/e0LSbQp5uSfhRryYXEjdFAXAS9Hh4KWop4C5A4+cxb+0G+KC4U7lIPjz?= =?us-ascii?Q?68/uSxcirWBZe2W5yScL+h0dxQ5vf2TN9dtI2f37PYFelnsH1dlrwoqZYArk?= =?us-ascii?Q?GIljq92LxxsiCnpdjEr5swZgCKnHoi10mrhw6/kZBBwcfRPodsRlYYLGwBDe?= =?us-ascii?Q?CIXPjr8+tprF+xKHpaDdpynPSAnZnIJJBPMfOKCBJ3mXyE1o7o0DcKPYdQRW?= =?us-ascii?Q?Q8KqnSAAQ/054HRVGOc5bFFowMOn0CKAtx8MvM7jrWyeuIS43P/NtwHOwLB5?= =?us-ascii?Q?PFJysZUkC372I5yJl5vx8wLMJytoq3LQDHIwOnjCpiBVVFAme6JwPKxszdmW?= =?us-ascii?Q?TWobO2nUP3MJ67mAZ4NKVtemHnhqt7S2eqAWmX8Dy+hozcDbGBH5z1pcclyF?= =?us-ascii?Q?QI3afSwLYYTrjFTz0acPaGBYbyWPsH7QNApddcJnoVBSVje8tA+ibm0agjNx?= =?us-ascii?Q?RKM8xVNtgR8tUwqf+YL0x1y1mLOj70BKtbDRSE6T/PZliU99ildXrpWzKzhp?= =?us-ascii?Q?rCgbE7dj4gmHVfHhEdRN2NCAJb+s470nQrDpPWwB2QHRVcDyZ3aNrBo/3W6y?= =?us-ascii?Q?Hx4GZC6f8xf801VqExFfx84ucFzLbEslJMX3T755W5U7tFUeK0YdPl8psmdV?= =?us-ascii?Q?28+O1TRyfR5tDGJV3fuU8wZdSWvmVdZkCOAxM3Srss9kquCyMW1ndv4+MQFI?= =?us-ascii?Q?j677mpZSPztlDQte7MVdprd7nygglAJVqjuY4IGdGRZRYinAE688bqF60Djf?= =?us-ascii?Q?fgl9pa97m7r7DP09surFTEe5LEusG6afSBkV9XiWrTVaEaUI3lBZguVUmNDU?= =?us-ascii?Q?mPx/wvstHmllb+w5mIMycc0eh02VG9jNi5ytLqP1pp8FxyWvOQjDjDMrd0ZX?= =?us-ascii?Q?B7SW3GNveJ6vaBWfrKk=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0501MB986; 6:Pm/2CR+H+bjWjyZVsd5bUejoaxj9eajB6YGhUR04fq7GLxm69ydzuzk+V7L9DKYXGqJPmRPkLOiIsLY+OCM0lpMfGjLCppvYSk20W0rtYXSQRnvN9QnNu7YDDnQyDgizt9W+kX4O8uEip4bCXmYypeNdQlEm4MqN6NDday79W2oBqbRJHAAIVy5Dz5EksZQTYay+x2pIvByuDphvDu51AhsP//Iigu/B0sn9BBuxEZvfRV8oYR/YMMt4AyN1aAVboPAUFD3i9zsNu6Rkk9vExuC8knBB07OsUhv41VgvaehBQxUu13wrDbeWgNTpAVoBJ2Bwa2RKeZnolzKze1YQ8w==; 5:b4Vp9zqF5lVUzhS8B/B0ivRGnDb9PZ9g53cCMH+y8qJw84FzSWtQ8Xs60FeruWnJy2t5WNU1sIzfQM8hW6S3+PcFXsySJpV81UaFLZ06erLf7NOnM5kflrqx9JLJ39DIcVYT+ydjuPqLsLscXuzkKw==; 24:CguQt141N/IZdMQEEDDHG2dXRRD5X+EtR7Ijs0CqtnUeZ6u7nfiZNJzORqdFVSLT4DdyfTtcoWc0kDJt6uX/UJ7vl3WWLaL/7FLCgkB9oiQ=; 7:Qc3X2F5R0RoyXT8ozzdeiGChNWQQ2t9cH9O8BcGdOMaOTsZ28ah9MPySiprx+WMpzhwL8CENa+PRKmoBrR7mT9usRhdlH2/PuJHICSjI18++5fzjzq4psZmd0AoAbcfBP7LDON4OICVOt43TcNHQalNjXg856oAOI232roRY8L5HaG9B0DEvqRHMd1K39rg5DIyLkyTNKUEWuvouc3jkq4aoy6QglYioU+KphlpKGEl07yMfT7qw/e4y3F7Rx4Cl SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2016 00:37:48.0386 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.18]; Helo=[p-emfe01a-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0501MB986 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2016 07:12:29 -0000 Bryan Drewery wrote: > > +# some targets involve old pre-built targets > > +# ignore mtime of shell > > +# and mtime of makefiles does not matter in meta mode > > +.MAKE.META.IGNORE_PATHS += \ > > + ${MAKEFILE} \ > > + ${SHELL} \ > > + ${SYS_MK_DIR} > > I think it could be problematic to ignore *.mk changes. The build If you're not concerned with build optimization, this can be disabled - but pretty much any sub-make for which there is a .meta file will be out-of-date by any changed to *.mk > commands may stay the same, but targets could grow new dependencies. If > those dependencies are already "met" then meta mode won't reconsider them. I'm not sure how easy it is to accomplish that situation. > Consider: > Build 1: > bar: > touch dep > touch bar > > foo: > touch foo > > all: bar foo > > In the first build, all generates dep, bar and foo. > > Then the code is changed to: > > bar: > touch bar > > dep: > touch notmade > touch dep > > foo: dep > touch foo > > all: foo bar > > Now in the second build, all finds bar command changes and rebuilds, > finds foo command is the same and that dep is already satisfied from the > last build. So 'notmade' is never made. Actually given you have missing-meta=yes target dep would be remade, either because there is no .meta file, or because its commands changed. Thus notmade should be.