From owner-svn-src-head@freebsd.org Sun Jan 22 20:08:09 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E88C2CBCB20; Sun, 22 Jan 2017 20:08:09 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8471C1821; Sun, 22 Jan 2017 20:08:09 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id d140so21378375wmd.2; Sun, 22 Jan 2017 12:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+4emPAaaCGVvkBzTS4NEiYCanDjW+QyerW5pGLUWQu8=; b=KKsyShFYgsfWBl9AGEdXzqiD2QBWcQnSl1oE9udCoixnCOQQZVdXR2I35xfnd1f7rz +GR7T/8bQU5lGrNd1tX56QfRDZGwiVezc/grbAmOmISPQqVl3b6OuDH7o0jvEqZz5fPY av5K5U1Tu7zjx9b4B6cbF/nVNfDYJkDqTepiQIiGU0zoIVfa0ZMVW258lYoP0sGHi0Un KQhoYEYjRav6+IfzHQMlfpcM9/YSyvabQRRv+R9+lDstEZJ7hLeD8h9Df5BMShD8CNa3 ja90gNr+KSjYpilFfGjMw/eLlpLJUiaC9dNsNYajBO1IauiC7Mn0ih+JCuBGeVWkP5Tv wWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=+4emPAaaCGVvkBzTS4NEiYCanDjW+QyerW5pGLUWQu8=; b=ERQ+3UILazc89ZGAPgW3LrJK1ABjvDMr2TvxSFC4scIpqdS7v0LQ0qGL3ii3QPRyZU G9LDmmqnAn1KwlCZcD3HLttl3jZdhOkpYhgPJj88uXzKwWzjXarVag5EVL7trYw/L04c pVYri6j1SGw6ObNUeY9p2zZIJJOv4WXUleDqtnCF4WLkkN+YZMvTAukT3e0qm0agtLVS TLh5spFYuj8gR7N7GGhegEPVHlOM/q+DmaZND8YJD42c81iADl8c+Xz56pnAErfx7E00 EgAoUu+UzBTRNRFOapOW2iHi+wLTX4/wLOaGB7MnsV2VChGj+vcqs4igTdrmomNOif4d wW4w== X-Gm-Message-State: AIkVDXJq4MdhCJQxLT/LEcwZeyYebSzlWwhYZ1qtx0PEIn97rh8MUD1/+zuFFqm2MySqbQ== X-Received: by 10.28.19.78 with SMTP id 75mr12157285wmt.108.1485115687745; Sun, 22 Jan 2017 12:08:07 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id z134sm17354152wmc.20.2017.01.22.12.08.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Jan 2017 12:08:06 -0800 (PST) Sender: Baptiste Daroussin Date: Sun, 22 Jan 2017 21:08:05 +0100 From: Baptiste Daroussin To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312650 - in head/usr.sbin/pw: . tests Message-ID: <20170122200805.l5vmo3nhodfl2m6q@ivaldir.etoilebsd.net> References: <201701222003.v0MK3JmF001620@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c5uszr3xaanb3aag" Content-Disposition: inline In-Reply-To: <201701222003.v0MK3JmF001620@repo.freebsd.org> User-Agent: NeoMutt/20170113 (1.7.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2017 20:08:10 -0000 --c5uszr3xaanb3aag Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 22, 2017 at 08:03:19PM +0000, Baptiste Daroussin wrote: > Author: bapt > Date: Sun Jan 22 20:03:18 2017 > New Revision: 312650 > URL: https://svnweb.freebsd.org/changeset/base/312650 >=20 > Log: > Really restore the old behaviour for pw usermod -m > =20 > It again reinstall missing skel files without overwriting changed one > Add a regression test about it > =20 > Reported by: ae > MFC after: 3 days >=20 > Modified: > head/usr.sbin/pw/psdate.c > head/usr.sbin/pw/pw_user.c > head/usr.sbin/pw/tests/pw_usermod.sh >=20 > Modified: head/usr.sbin/pw/psdate.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.sbin/pw/psdate.c Sun Jan 22 19:50:23 2017 (r312649) > +++ head/usr.sbin/pw/psdate.c Sun Jan 22 20:03:18 2017 (r312650) > @@ -41,12 +41,8 @@ static const char rcsid[] =3D > static int > numerics(char const * str) > { > - int rc =3D isdigit((unsigned char)*str); > =20 > - if (rc) > - while (isdigit((unsigned char)*str) || *str =3D=3D 'x') > - ++str; > - return rc && !*str; > + return (str[strspn(str, "0123456789x")] =3D=3D '\0'); > } Oups that wasn't supposed to be there but anyway it is in now Bapt --c5uszr3xaanb3aag Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAliFESEACgkQY4mL3PG3 Plp5lxAAuezpGgmXLAynp5s9yUen99I4MNoElWgTHAWbjO1xHlGzjgNRKM6NpU3n 5vT5xsd/t2lKkdamBDbuK7P5paJMDQ9CtFywG4yujPpHmjTZnlDNHVyu1ToHi6jX FJS4u1JUk6jbOGh0VppLl7PnuwQuWaX7o6rwdybv4GMXd27FU6yJD2utI8p1jZFR PD/Wa/hYrr61QFAnGGTvn8ssKBHMa+YBrfF9LeWf9KbjU0JKlBO4WRHqhDK3BHFZ 8u6u3YDqO6ADJkOcFdSSqTuZ1awEh46peQVCqa4wqc8rxIRr1kWb8mQPBUjTaINJ mgzC3w1SWg7W2amcVCwH0LU6mGH/yLm1zbjL4ihCnsz+PyVVYSO3KccNBEjnZK93 6nfKIzB6aYl/vZXn/Jbhdrg9K3NFmmDab69NrcZxo9s5i3uTqtPCi8zfdGxSWTJ1 OJlM4gxdCn7BmrC5eeLe0V4KKNzeoBiHuQ64LX4kenvRWw/gVPx1tEzDZxdcIkkL RHI2lhbMJRYs9CPqEK72EWoX2xM5TrYBfNWuKU21T89tdpVIXRMmtAJWKnt0vNF4 ZgHKbMwrhXNPqBxKu99HbSvWFlLBRly+MQBYDbSTi2CKlpgEaDLmjclc/Tc6Ug7J MwTNTmkWHISY5Upx14XwGY2ju1yg3A/MFBLMDk3E6F1G7GX1sZA= =7n6b -----END PGP SIGNATURE----- --c5uszr3xaanb3aag--