From owner-freebsd-current@FreeBSD.ORG  Mon Aug 20 10:38:37 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0B3ED16A420;
	Mon, 20 Aug 2007 10:38:37 +0000 (UTC) (envelope-from dds@aueb.gr)
Received: from mx-out-01.forthnet.gr (mx-out.forthnet.gr [193.92.150.103])
	by mx1.freebsd.org (Postfix) with ESMTP id 5BA9B13C458;
	Mon, 20 Aug 2007 10:38:35 +0000 (UTC) (envelope-from dds@aueb.gr)
Received: from mx-av-01.forthnet.gr (mx-av.forthnet.gr [193.92.150.27])
	by mx-out-01.forthnet.gr (8.13.8/8.13.8) with ESMTP id l7KAcKGg029120; 
	Mon, 20 Aug 2007 13:38:20 +0300
Received: from MX-IN-04.forthnet.gr (mx-in-04.forthnet.gr [193.92.150.163])
	by mx-av-01.forthnet.gr (8.14.1/8.14.1) with ESMTP id l7KAcK0R017355;
	Mon, 20 Aug 2007 13:38:20 +0300
Received: from [213.16.200.36] (ppp1-36.kef.forthnet.gr [213.16.200.36])
	by MX-IN-04.forthnet.gr (8.14.1/8.14.1) with ESMTP id l7KAcAwG011497;
	Mon, 20 Aug 2007 13:38:12 +0300
Authentication-Results: MX-IN-04.forthnet.gr smtp.mail=dds@aueb.gr; spf=neutral
Authentication-Results: MX-IN-04.forthnet.gr header.from=dds@aueb.gr;
	sender-id=neutral
Message-ID: <46C96EFE.6070400@aueb.gr>
Date: Mon, 20 Aug 2007 13:37:50 +0300
From: Diomidis Spinellis <dds@aueb.gr>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.8.1.4) Gecko/20070509 SeaMonkey/1.1.2
MIME-Version: 1.0
To: Jeff Roberson <jroberson@chesapeake.net>
References: <20070819214953.I1099@fledge.watson.org>
	<46C8C2E6.9030405@aueb.gr> <20070819164823.H568@10.0.0.1>
In-Reply-To: <20070819164823.H568@10.0.0.1>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Mon, 20 Aug 2007 11:18:48 +0000
Cc: attilio@FreeBSD.ORG, jeff@FreeBSD.ORG, Robert Watson <rwatson@FreeBSD.ORG>,
	current@FreeBSD.ORG
Subject: Re: Crash in accounting code: encode_long(), due to bad rusage data?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Aug 2007 10:38:37 -0000

Jeff Roberson wrote:
>> Robert Watson wrote:
>>> I recently upgraded two servers from FreeBSD 6-STABLE to FreeBSD 
>>> 7-CURRENT in anticipation of the forthcoming release.  Both of them 
>>> run with accounting enabled at all times.  When a large pine session 
>>> was exiting on one of the two boxes, I ran into the following panic:
>>>
>>> panic: encode_long: -ve value -32749
[...]
> What do you think about simply putting in a max value if we overflow?  
> We could then make a note about it in process accounting docs.  We might 
> want to fix this in rusage as well.

Encoding LONG_MAX and issuing a printf warning is I think a reasonable 
solution.  I'll be away from a broadband connection until Friday, so if 
anybody else wants to commit this, go ahead.  Otherwise I can do it over 
the coming weekend.

Diomidis Spinellis - http://www.spinellis.gr