From owner-freebsd-virtualization@freebsd.org Tue Feb 16 09:29:18 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E692AA8EC9 for ; Tue, 16 Feb 2016 09:29:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.rbsd.freebsd.org (unknown [IPv6:2607:fc50:2000:101::1bb:73]) by mx1.freebsd.org (Postfix) with ESMTP id EF72A17E7 for ; Tue, 16 Feb 2016 09:29:17 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346) id E8B4E33205D8; Tue, 16 Feb 2016 09:29:17 +0000 (UTC) Date: Tue, 16 Feb 2016 09:29:17 +0000 To: freebsd-virtualization@freebsd.org From: "sepherosa_gmail.com (Sepherosa Ziehau)" Reply-to: D5291+333+9e687f0ec04aca99@reviews.freebsd.org Subject: [Differential] [Commented On] D5291: hyperv/vmbus: Select an IDT vector has lower priority than LAPIC timer and IPIs vectors Message-ID: <1942fc746b0d3c4587eb14513aec167c@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D5291: hyperv/vmbus: Select an IDT vector has lower priority than LAPIC timer and IPIs vectors X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: M2VhMjA1ZWQ4ODNjZTIxMmJiYjJmZGJiYWNkIFbC6+0= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.20 List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 09:29:18 -0000 sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5291#112900, @royger wrote: > I guess this supersedes https://reviews.freebsd.org/D5254? I would expand the commit message so that it's explicitly stated why the hypervisor vector should have a lower priority. Oh, I didn't see 5254 at all, thank you for pointing it to me :) hyperv interrupt currently only services so called 'external devices' (it's event timer is not yet used; even if it was used, it would be serviced by the same IDT vector, so vector priority would not matter). So we don't want to delay LAPIC timer interrupt or IPIs, if all three types of interrupt happens at the same time. Its just a POC same as 5254, which is also a POC IMHO, what we really need is to have a hyperv file reside in kernel and we will need to change native_lapic_create() in the same way as XEN. Well, I think its probably high time to add a hyperv file to always reside in kernel, since we have a TSC calibration fix will need that too. REVISION DETAIL https://reviews.freebsd.org/D5291 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, royger Cc: freebsd-virtualization-list