From owner-freebsd-x11@FreeBSD.ORG Fri Apr 4 18:48:14 2014 Return-Path: Delivered-To: x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0E26D9A2; Fri, 4 Apr 2014 18:48:14 +0000 (UTC) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 73E68249; Fri, 4 Apr 2014 18:48:13 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id m15so3864169wgh.3 for ; Fri, 04 Apr 2014 11:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=vmHfyyYt01TYwg+thpOyIBUxZpuuQ335pvsdOW7ot1I=; b=kKw+oAQgMz7ZOKXZkCz8xpSEoTxYfXfEqlIypSXMCuGSV69o7iCpbh6E+pEE1FN6Zb lDo7jbLswruHemZXzB2G+854bz99PWQf6I2o+yzKBLbZXFaVEh512ZpcET0bHgkw8Jn9 TOr8eu9cIUXK97nRFh/BN3BDx2v4kK0xaBwrRTJdTzMJ4PvHvbImhIu0uZGE7WU5kDJF BEGwv/rkV6tGyvZ7tQuIWkE9ukLsDxbBfSxJfyp6KZwrtINuAbJ9cGcj4IomuKgSN5Gv xhxYp9V1HYUWt3Bp4buFP0Q8u5a7YiqFGp+BAh48ieb2N419Udu5yAArPwxxFxkO7+28 QsqA== X-Received: by 10.180.98.165 with SMTP id ej5mr6650020wib.33.1396637291766; Fri, 04 Apr 2014 11:48:11 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id vp5sm13574836wjc.31.2014.04.04.11.48.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Apr 2014 11:48:10 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 4 Apr 2014 20:48:08 +0200 From: Baptiste Daroussin To: Julio Merino Subject: Re: xorg-server fails to build as non-root Message-ID: <20140404184808.GE97416@ivaldir.etoilebsd.net> References: <20140404183304.GA85500@mastodon.meroh.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="idY8LE8SD6/8DnRI" Content-Disposition: inline In-Reply-To: <20140404183304.GA85500@mastodon.meroh.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2014 18:48:14 -0000 --idY8LE8SD6/8DnRI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 04, 2014 at 02:33:04PM -0400, Julio Merino wrote: > Hello, >=20 > The staging phase of xorg-server fails when run as non-root because the > package installation tries to make the Xorg binary setuid root. >=20 > The patch below fixes it. I'm not sure if there would be a better and > preferrable alternative. >=20 > Thoughts? >=20 > Thanks! >=20 >=20 > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile (revision 349914) > +++ Makefile (working copy) > @@ -109,6 +109,11 @@ > .if ${PORT_OPTIONS:MSUID} > CONFIGURE_ARGS+=3D--enable-install-setuid=3Dyes > PLIST_SUB+=3D SUID=3D"" > + > +# The configure script tries to detect if we can install Xorg as root so= that > +# the binary can be made setuid later. If we are not root, this obvious= ly > +# fails at one point or another. > +NEED_ROOT=3D yes > .else > CONFIGURE_ARGS+=3D--enable-install-setuid=3Dno > PLIST_SUB+=3D SUID=3D"@comment " > _______________________________________________ > freebsd-x11@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-x11 > To unsubscribe, send any mail to "freebsd-x11-unsubscribe@freebsd.org" I will come with a better patch not adding NEED_ROOT NEED_ROOT was a mistake I should not have done ;) regards, Bapt --idY8LE8SD6/8DnRI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iEYEARECAAYFAlM+/mgACgkQ8kTtMUmk6EzEWACeK0qYXb3hE6ZG/91KyLp86z+L IO8AnR/rEA++aeJ07sDE5B3EyvVtsBbk =DuXJ -----END PGP SIGNATURE----- --idY8LE8SD6/8DnRI--