From owner-freebsd-current Wed Jan 1 11:12:48 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 287F737B401; Wed, 1 Jan 2003 11:12:46 -0800 (PST) Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5405343EC2; Wed, 1 Jan 2003 11:12:45 -0800 (PST) (envelope-from mjacob@feral.com) Received: from mailhost.feral.com (mjacob@mailhost.feral.com [192.67.166.1]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id h01JCd722235; Wed, 1 Jan 2003 11:12:39 -0800 (PST) (envelope-from mjacob@feral.com) Date: Wed, 1 Jan 2003 11:12:39 -0800 (PST) From: Matthew Jacob X-X-Sender: mjacob@beppo Reply-To: mjacob@feral.com To: Mike Barcroft Cc: current@FreeBSD.org Subject: Re: alpha tinderbox failure In-Reply-To: <20030101095143.P6833@espresso.q9media.com> Message-ID: <20030101111031.D20052-100000@beppo> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I already know this- I just hadn't checked it in a change because I was trying to get one of my alphas current. Sam Leffler brought it to my attention the other day. This is for LINT, btw. Also- is casting to 'long' for bus_addr_t and bus_size_t the best idea? Shouldn't it be cast to the maximum width integer (long long)? -matt On Wed, 1 Jan 2003, Mike Barcroft wrote: > Dag-Erling Smorgrav writes: > > ===> vinum > > "Makefile", line 4453: warning: duplicate script for target "geom_bsd.o" ignored > > cc1: warnings being treated as errors > > /h/des/src/sys/dev/isp/isp_pci.c: In function `tdma_mkfc': > > /h/des/src/sys/dev/isp/isp_pci.c:1543: warning: unsigned int format, different type arg (arg 5) > > /h/des/src/sys/dev/isp/isp_pci.c:1543: warning: int format, different type arg (arg 6) > > /h/des/src/sys/dev/isp/isp_pci.c:1572: warning: unsigned int format, different type arg (arg 6) > > /h/des/src/sys/dev/isp/isp_pci.c:1572: warning: unsigned int format, different type arg (arg 7) > > *** Error code 1 > > Proposed fix: > > %%% > Index: isp_pci.c > =================================================================== > RCS file: /work/repo/src/sys/dev/isp/isp_pci.c,v > retrieving revision 1.89 > diff -u -r1.89 isp_pci.c > --- isp_pci.c 11 Oct 2002 17:28:01 -0000 1.89 > +++ isp_pci.c 1 Jan 2003 14:56:25 -0000 > @@ -1538,9 +1538,10 @@ > cto->rsp.m0.ct_dataseg[cto->ct_seg_count].ds_count = > dm_segs[segcnt].ds_len; > cto->rsp.m0.ct_xfrlen += dm_segs[segcnt].ds_len; > - isp_prt(isp, ISP_LOGTDEBUG1, "isp_send_ctio2: ent0[%d]0x%x:%d", > - cto->ct_seg_count, dm_segs[segcnt].ds_addr, > - dm_segs[segcnt].ds_len); > + isp_prt(isp, ISP_LOGTDEBUG1, > + "isp_send_ctio2: ent0[%d]0x%lx:%lu", > + cto->ct_seg_count, (unsigned long)dm_segs[segcnt].ds_addr, > + (unsigned long)dm_segs[segcnt].ds_len); > } > > while (segcnt < nseg) { > @@ -1567,9 +1568,10 @@ > crq->req_dataseg[seg].ds_base = dm_segs[segcnt].ds_addr; > crq->req_dataseg[seg].ds_count = dm_segs[segcnt].ds_len; > isp_prt(isp, ISP_LOGTDEBUG1, > - "isp_send_ctio2: ent%d[%d]%x:%u", > + "isp_send_ctio2: ent%d[%d]%lx:%lu", > cto->ct_header.rqs_entry_count-1, seg, > - dm_segs[segcnt].ds_addr, dm_segs[segcnt].ds_len); > + (unsigned long)dm_segs[segcnt].ds_addr, > + (unsigned long)dm_segs[segcnt].ds_len); > cto->rsp.m0.ct_xfrlen += dm_segs[segcnt].ds_len; > cto->ct_seg_count++; > } > %%% > > Best regards, > Mike Barcroft > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message