From owner-svn-src-head@freebsd.org Thu Jun 14 03:05:24 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 583851016FDE for ; Thu, 14 Jun 2018 03:05:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE7326D6CA for ; Thu, 14 Jun 2018 03:05:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x234.google.com with SMTP id 76-v6so6450514itx.4 for ; Wed, 13 Jun 2018 20:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YlWPPIDek7HG+pb0hYSFFuczJFPhIVfpY85boSQ+w3k=; b=lotmwiPFrL8AV/Zr3v9wdWdNXapT8En0+9bQV+lrGgUNaEN8wFSLzj/HylEzqZ7a/U lNkHZsfQK22MjzEL8hjmtwjhaMB/+DVvHyKgRfYyZZL2MMDPfT6V34wGPREKzXdOu2hS tk03wNgs5UfL8HqNfPGieoskVzeS6WePgVDGtk5b4g9tMC6rKDp1fNXh8/At6qi/ebej jXXYg1lJMh+iG1s71TCLB6Xh+/9EOxExTZq/e33LeSgUI9yxYYkuouqOtkAr8ylbb/eY 82ggvtV5Dn12UKRU7nqLy22aw9YGOHWgsNCg23AlOMaO3bTSU+uK9J3mkkyyb/glFFns 7Nyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=YlWPPIDek7HG+pb0hYSFFuczJFPhIVfpY85boSQ+w3k=; b=ULXB0mGJ2khePXBPQorcakOLznJpjJs5E7o2HhhN+zd/gHPpIOTRYOqYVMxGGKjUYm ON7plkieIzFOOebz6JwEDtTvUEAfIPaa/NDjMr8SFVCpxH+t5I+gutsUxRuuxjlCA3S+ zytJ8qjnMATWAGR0OBLpkrXzpaK4YSCGUO/DKzG8GKkcscIbCJIfFKw1pTBZtRsMk6Pp b9kbz9gB9GpY36YoF4oa3a5ePJ5w2ARp3RN5gaTUYjzbzHS6/Vzq1dXH1/deHhOAPHYO JRrN1hDkp8rG8jISwVpbhrl62v+SNMHzKeDpNKfSq/VfliPxgcEh4uMvV2YrC35K+cKR bpxA== X-Gm-Message-State: APt69E3zTKAJ2r1Pafhe0wBqot2O7bkYUbwkPQInGCctC5f72apXSVcs rKiqmiHsrSW9BhwFCYj/BDiIaUSLl55cBYdkXhadnw== X-Google-Smtp-Source: ADUXVKI5bFVWLX8KOykt/pv8/K8GwLFRvIFrzkO4PneLyB8bLqlG8o1JGc3vQC8ftohnoHS5ko9hSk27ipGNj1Z1gag= X-Received: by 2002:a24:64ce:: with SMTP id t197-v6mr624906itc.36.1528945523108; Wed, 13 Jun 2018 20:05:23 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 20:05:22 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201806140303.w5E33BYj042496@pdx.rh.CN85.dnsmgr.net> References: <201806132200.w5DM03bF097193@repo.freebsd.org> <201806140303.w5E33BYj042496@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 13 Jun 2018 21:05:22 -0600 X-Google-Sender-Auth: WyHULtL9Bc-3hYw2NazU_5uhgqA Message-ID: Subject: Re: svn commit: r335091 - head/sbin/nvmecontrol To: "Rodney W. Grimes" Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 03:05:24 -0000 On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: imp > > Date: Wed Jun 13 22:00:02 2018 > > New Revision: 335091 > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > > > Log: > > Make it possible to use print_controller from another program > > > > Rename print_controller to nvme_print_controller. Put it in its > > own file for easy inclusion. Move util.c to be nc_util.c to not > > conflict with camcontrol. add nvecontrol_ext.h to define shared > > interfaces. > > > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D15371 > > > > Added: > > head/sbin/nvmecontrol/identify_ext.c > > - copied, changed from r335089, head/sbin/nvmecontrol/identify.c > > head/sbin/nvmecontrol/nc_util.c > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props changed) > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > ... > > > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > r335089, head/sbin/nvmecontrol/util.c) > > ============================================================ > ================== > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > (r335089, copy source) > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 2018 > (r335091) > > @@ -1,7 +1,8 @@ > > /*- > > - * Copyright (c) 2017 Netflix, Inc > > - * All rights reserved. > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > * > > + * Copyright (C) 2018 Netflix > > You moved a copyright forward, that is not proper to do. > Thought it was. I honestly don't care where (nor does my employer), so if you want to tweak it to be more conforming, be my guest. > Not sure about dropping the , Inc either. Doesn't matter. Different Netflix committers do different things and I was trying to move towards uniformity. Warner