From owner-freebsd-current  Wed Oct 22 00:22:46 1997
Return-Path: <owner-freebsd-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id AAA12657
          for current-outgoing; Wed, 22 Oct 1997 00:22:46 -0700 (PDT)
          (envelope-from owner-freebsd-current)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id AAA12642
          for <current@FreeBSD.ORG>; Wed, 22 Oct 1997 00:22:41 -0700 (PDT)
          (envelope-from bde@zeta.org.au)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.6.9) id RAA03072; Wed, 22 Oct 1997 17:18:27 +1000
Date: Wed, 22 Oct 1997 17:18:27 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199710220718.RAA03072@godzilla.zeta.org.au>
To: current@FreeBSD.ORG, roberto@keltia.freenix.fr
Subject: Re: nullfs & current UPDATE!
Sender: owner-freebsd-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>I tried to be consistent with the code around in null_vnops.c... Do you
>think we should change both miscfs/nullfs and miscfs/umapfs to conform to
>style(9) ? The code has been like this since 4.4BSD-lite...

No, don't change old code.  Just write perfect new code :-).

>> temporary variables.  `lowervp' can be written fairly concisely as
>> VTONULL(ap->a_vp)->null_lowervp.  In fact, there is already a macro
>> NULLVPTOLOWERVP() for this.  It seems to be used consistently to set
>> `lowervp' variables that are passed to other functions and not used again,
>> as lowervp is here.
>
>It is not used consistly in nullfs :-(

It was in the Lite2 version :-).  All cases except one where
xp->null_lowervp is used already had xp handy.  The one exception was
a FreeBSD addition in null_vfsops.c:nullfs_mount().

Bruce