From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Nov 30 00:51:14 2005
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@FreeBSD.org
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6123A16A41F
	for <freebsd-ports-bugs@FreeBSD.org>;
	Wed, 30 Nov 2005 00:51:14 +0000 (GMT)
	(envelope-from paulh@bigbird.logicsquad.net)
Received: from bigbird.logicsquad.net (ppp131-102.lns2.adl2.internode.on.net
	[59.167.131.102])
	by mx1.FreeBSD.org (Postfix) with SMTP id 860C643D45
	for <freebsd-ports-bugs@FreeBSD.org>;
	Wed, 30 Nov 2005 00:51:06 +0000 (GMT)
	(envelope-from paulh@bigbird.logicsquad.net)
Received: (qmail 94146 invoked by uid 1001); 30 Nov 2005 00:51:03 -0000
Date: Wed, 30 Nov 2005 11:21:03 +1030
From: "Paul A. Hoadley" <paulh@logicsquad.net>
To: Volker Stolz <vs@FreeBSD.org>
Message-ID: <20051130005103.GB93035@bigbird.logicsquad.net>
References: <200511291335.jATDZkD8037402@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200511291335.jATDZkD8037402@freefall.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/89703: [maintainer-update] textproc/refdb to 0.9.6
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Nov 2005 00:51:14 -0000

On Tue, Nov 29, 2005 at 01:35:46PM +0000, Volker Stolz wrote:

> Although your intent to use versioned dependencies is honorable,
> it'll mean that LIB_DEPENDS is incomplete (missing
> libdbi).

LIB_DEPENDS is similarly incomplete in the current version of this
port.  Dependency on libdbi was only ever expressed indirectly by
BUILD_DEPENDS on the various backend drivers in libdbi-drivers.  For
example, if the user selected 'MySQL' as the DB backend for refdb, the
Makefile adds the following:

USE_MYSQL=      yes
# If libdbi-drivers has been built without MySQL driver, abort
.if exists(${LOCALBASE}/lib/dbd) && !exists(${LOCALBASE}/lib/dbd/libmysql.so)
IGNORE=         Rebuild databases/libdbi-drivers with MySQL support
.elif !exists(${LOCALBASE}/lib/dbd)
BUILD_DEPENDS+= ${LOCALBASE}/lib/dbd:${PORTSDIR}/databases/libdbi-drivers
.endif

The .if is true if libdbi exists, but libmysql.so was never installed.
There's no way to automate the consequence, as libdbi-drivers uses
OPTIONS in its Makefile, and so we can't force libmysql.so to be
built.  The .elif is true if libdbi was never built, in which case we
make database/libdbi-drivers a BUILD_DEPENDS, and rely on the user to
select the right backend.

> Unfortunately, I don't see an easy fix. I'd say let's go for a
> regular LIB_DEPENDS again since running with stale dependencies is
> never really supported.

I don't see an easy fix either, and I think even the approach for the
existing port is a bit of a mess.  Are you saying it would be
sufficient to add 'dbi:${PORTSDIR}/databases/libdbi' to LIB_DEPENDS?


-- 
Paul.

w  http://logicsquad.net/
h  http://paul.hoadley.name/