From owner-freebsd-fs  Sun Mar  1 02:57:05 1998
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id CAA25438
          for freebsd-fs-outgoing; Sun, 1 Mar 1998 02:57:05 -0800 (PST)
          (envelope-from owner-freebsd-fs@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA25432
          for <fs@FreeBSD.ORG>; Sun, 1 Mar 1998 02:57:02 -0800 (PST)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id VAA09758;
	Sun, 1 Mar 1998 21:54:22 +1100
Date: Sun, 1 Mar 1998 21:54:22 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199803011054.VAA09758@godzilla.zeta.org.au>
To: bde@zeta.org.au, michaelh@cet.co.jp
Subject: Re: syncer / SMP question
Cc: eivind@yes.no, fs@FreeBSD.ORG, jlemon@americantv.com
Sender: owner-freebsd-fs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

>> >This is about half the code of the previous version, and to me it is
>> >much clearer than before.  
>> 
>> It seems to make one case simpler.  How would you handle a return from
>> inside the loop, like the one in getfsstat()?  Requiring a single exit
>> point is not an option :-).
>
>goto out;

Not an option :-), and leaves mp locked (which you can't know about since
its locking is hidden in the loop macros).  In general, you would need
macros for all sorts of abnormal loop exits.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message